-
Notifications
You must be signed in to change notification settings - Fork 160
updates deps 23 jul 2025 #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…it into update_deps_22_apr_2025
….java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dsgrieve - Thought you might like that the pesky closing verticles during tests was finally fixable with vert.x 5 :-) |
…kit into updates_deps_23_jul_2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates project dependencies to newer versions and migrates the Vert.x integration from version 4.5.14 to 5.0.2. The update includes modernizing asynchronous API usage patterns to align with Vert.x 5.x conventions and resolving potential double-undeploy issues in verticles.
- Updates multiple Maven plugin and dependency versions including Vert.x core from 4.5.14 to 5.0.2
- Migrates from deprecated async API patterns to the new
.onComplete()
callback pattern - Removes automatic verticle undeployment logic to prevent double-undeploy scenarios
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
vertx/pom.xml | Updates Vert.x core dependency from 4.5.14 to 5.0.2 |
pom.xml | Updates various Maven plugin versions and dependencies |
VertxJVMEventChannel.java | Migrates deployVerticle callback to use onComplete pattern |
VertxDataSourceChannel.java | Migrates deployVerticle callback to use onComplete pattern |
VertxChannel.java | Updates close method to use onComplete and improves error logging |
JVMEventVerticle.java | Removes automatic undeploy and updates completion handler |
DataSourceVerticle.java | Removes automatic undeploy and updates completion handler |
.mvn/wrapper/maven-wrapper.properties | Updates Maven wrapper to version 3.9.11 |
.github/copilot-instructions.md | Adds comprehensive project documentation and coding guidelines |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.