Unified logs missing time stamps causes NPE #274
Comments
ghost
pushed a commit
that referenced
this issue
Mar 2, 2023
* 🐛 fix for issue #274 * refactor: debug NPE to improve robustness when GCToolKit is being used in unexpected ways * refactor: update test data version and move from snapshot to full release * refactor: update versions in poms * Update api/src/main/java/com/microsoft/gctoolkit/time/DateTimeStamp.java * Update IT/src/test/java/com/microsoft/gctoolkit/integration/CaptureJVMTerminationEventTest.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> * Update IT/src/test/java/com/microsoft/gctoolkit/integration/MissingAnnotationTest.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> * Update api/src/main/java/com/microsoft/gctoolkit/time/DateTimeStamp.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> * Update api/src/main/java/com/microsoft/gctoolkit/time/DateTimeStamp.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> * Update api/src/main/java/com/microsoft/gctoolkit/time/DateTimeStamp.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> * Update api/src/main/java/com/microsoft/gctoolkit/time/DateTimeStamp.java Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> * Update DateTimeStamp.java DateTimeStamp implements Comparable<DateTimeStamp> so delegate before and after methods to the compareTo method * tidy: review of PR * tidy: finally to ensure the close is always called on the channel --------- Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> Co-authored-by: David Grieve <dagrieve@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unified GC logs without a timestamp will cause NPE as all of the code expects a timestamp. Use first date stamp as a base of 0.000 seconds and then synthetically generate timestamps for each JVMEvent.
The text was updated successfully, but these errors were encountered: