[fix][menu-item]: Emit current state when checked change event fires #33029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
eljefe223
force-pushed
the
users/jes/menu-item-checked-change-event
branch
from
3558540 to
dbe7356
Compare
marchbox
approved these changes
Oct 11, 2024
change/@fluentui-web-components-32b505fd-a856-47b9-9639-f9ce57af0ce4.json
Show resolved
Hide resolved
mlijanto
reviewed
Oct 11, 2024
radium-v
reviewed
Oct 11, 2024
radium-v
changed the title
davatron5000
approved these changes
Oct 11, 2024
eljefe223
force-pushed
the
users/jes/menu-item-checked-change-event
branch
from
dbe7356 to
9df0287
Compare
radium-v
reviewed
Oct 14, 2024
radium-v
approved these changes
Oct 14, 2024
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
eljefe223
force-pushed
the
users/jes/menu-item-checked-change-event
branch
from
3a69f68 to
fcb800f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
changecustom event fires whenmenu-itembecomes checked and unchecked. When role is set tomenuitemradioand another menu-item is checked it's difficult to decern between the menu-item being checked and the menu-item being unchecked.New Behavior
This change emits the current state of the checked property so a developer can properly listen for the item being checked.
Related Issue(s)