Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-components): add button primary forced colors #32419

Merged

Conversation

davatron5000
Copy link
Contributor

Previous Behavior

  • Missing Primary button appearance in forced-colors mode

New Behavior

  • Add primary button appearance in forced-colors mode
  • Improve disabled state in forced-colors mode

Related Issue(s)

Screenshots

Before After
Light Screenshot 2024-08-29 at 10 33 54 AM Screenshot 2024-08-29 at 10 27 41 AM
Dark Screenshot 2024-08-29 at 10 34 04 AM Screenshot 2024-08-29 at 10 27 10 AM

@davatron5000 davatron5000 requested a review from a team as a code owner August 29, 2024 15:36
@mohamedmansour
Copy link
Contributor

lgtm!

@davatron5000 davatron5000 changed the title Fix/button primary forced colors fix(web-components): add button primary forced colors Aug 29, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 29, 2024

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 29, 2024

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@davatron5000 davatron5000 force-pushed the fix/button-primary-forced-colors branch from 8425012 to d4497f6 Compare August 29, 2024 18:17
@davatron5000 davatron5000 enabled auto-merge (squash) August 29, 2024 18:18
@davatron5000 davatron5000 merged commit 6f53f97 into microsoft:master Aug 29, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Primary Button High Contrast doesn't work
5 participants