Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-components): add fluent-textarea #32037

Merged
merged 95 commits into from
Aug 13, 2024
Merged

feat(web-components): add fluent-textarea #32037

merged 95 commits into from
Aug 13, 2024

Conversation

marchbox
Copy link
Contributor

@marchbox marchbox commented Jul 17, 2024 •
edited
Loading

Previous Behavior

n/a

New Behavior

Add fluent-textarea element

Related Issue(s)

marchbox and others added 25 commits July 11, 2024 13:55
@marchbox
scaffold textarea from changes by @radium-v
a0667bb
@marchbox
Merge branch 'microsoft:master' into users/machi/textarea
2b1d6dc
@marchbox
clean up js class
0cfb15c
@marchbox
make resize button inaccessible by at and keyboard
2872cbf
@marchbox
match design specs
b46dbff
@marchbox
Merge branch 'microsoft:master' into users/machi/textarea
26d6d6b
@marchbox
scaffold the resizing feature
f12a5a0
@marchbox
handle resizing
037a251
@marchbox
Merge branch 'microsoft:master' into users/machi/textarea
e0c6d21
@marchbox
restrict vertical and horizontal resizing
474ffa1
@marchbox
use passive event
8b52a21
@marchbox
add story of html code inside textarea
da439f2
@marchbox
add resize handle styles
f190eab
@marchbox
fix placeholder sizing issue
f9d1f5c
@marchbox
show and hide placeholder
833668f
@marchbox
set form value on input
f4386a2
@marchbox
fix initial value
e4f4a63
@marchbox
delegate focus for label clicks
6506e40
@marchbox
handle validity checking
05787b7
@marchbox
implement spellcheck
5acafaa
@marchbox
set validity with minimal default messages
684b163
@marchbox
set validity in validity and validationMessage getters
1778b2e
@marchbox
update stories and fix issues
3f547ae
@marchbox
Merge branch 'microsoft:master' into users/machi/textarea
eacf057
@marchbox
fix lint and format
2630e69
@marchbox marchbox self-assigned this Jul 17, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 17, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@marchbox marchbox requested a review from radium-v August 1, 2024 22:20
davatron5000
davatron5000 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@davatron5000 davatron5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, this looks great. I think the label API is maybe the only sticky point we need to get through.

packages/web-components/src/textarea/textarea.styles.ts Show resolved Hide resolved
packages/web-components/src/textarea/textarea.ts Show resolved Hide resolved
packages/web-components/src/textarea/textarea.template.ts Show resolved Hide resolved
packages/web-components/src/textarea/textarea.stories.ts Outdated Show resolved Hide resolved
packages/web-components/src/textarea/textarea.spec.ts Show resolved Hide resolved
packages/web-components/src/helpers.tests.ts Show resolved Hide resolved
radium-v
radium-v reviewed Aug 8, 2024
View reviewed changes
packages/web-components/src/textarea/textarea.stories.ts Outdated Show resolved Hide resolved
packages/web-components/src/textarea/textarea.stories.ts Outdated Show resolved Hide resolved
packages/web-components/src/textarea/textarea.spec.ts Outdated Show resolved Hide resolved
packages/web-components/src/helpers.tests.ts Outdated Show resolved Hide resolved
packages/web-components/src/helpers.tests.ts Outdated Show resolved Hide resolved
packages/web-components/src/helpers.tests.ts Outdated Show resolved Hide resolved
packages/web-components/src/helpers.tests.ts Outdated Show resolved Hide resolved
packages/web-components/src/textarea/textarea.spec.ts Outdated Show resolved Hide resolved
packages/web-components/src/textarea/textarea.stories.ts Outdated Show resolved Hide resolved
@radium-v radium-v self-requested a review August 13, 2024 17:10
@marchbox marchbox enabled auto-merge (squash) August 13, 2024 17:16
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 13, 2024 •
edited
Loading

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@marchbox marchbox merged commit bf96935 into microsoft:master Aug 13, 2024
16 of 18 checks passed
@marchbox marchbox deleted the users/machi/textarea branch August 13, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davatron5000 davatron5000 davatron5000 approved these changes

@radium-v radium-v radium-v approved these changes

Assignees

@marchbox marchbox

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component: Textarea
4 participants
@marchbox @fabricteam @davatron5000 @radium-v