fix(motion): improve Web Animations API detection in tests #32029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
fix/motion-more-robust-check
branch
from
fccbf2a to
ce999b6
Compare
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 36 | 41 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 622 | 641 | 5000 | |
| Button | mount | 303 | 300 | 5000 | |
| Field | mount | 1139 | 1141 | 5000 | |
| FluentProvider | mount | 713 | 699 | 5000 | |
| FluentProviderWithTheme | mount | 88 | 90 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 41 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 80 | 10 | |
| MakeStyles | mount | 866 | 875 | 50000 | |
| Persona | mount | 1762 | 1776 | 5000 | |
| SpinButton | mount | 1427 | 1316 | 5000 | |
| SwatchPicker | mount | 1649 | 1659 | 5000 |
fabricteam
reviewed
Jul 17, 2024
ling1726
reviewed
Jul 23, 2024
packages/react-components/react-motion/library/src/hooks/useAnimateAtoms.ts
Show resolved
Hide resolved
ling1726
approved these changes
Jul 23, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 25, 2024
* master: (77 commits) chore(react-examples): replace storybook deprecated api with static stories (microsoft#32074) [chore]: create base class for accordion item and remove style and layout specific api (microsoft#32102) release: applying package updates - web-components chore(web-components): add test for complex focus management (microsoft#32009) [chore]: create base class for avatar and remove style and layout specific api (microsoft#32083) [chore]: create base class for text input and remove style and layout specific api (microsoft#32080) release: applying package updates - web-components chore:(react-nav-preview) Scaffold AppItem (microsoft#32088) docs(`react-teaching-popover`): Adding subcomponents' API to `TeachingPopover` documentation page (microsoft#32084) feat(web-components): relax setTheme() argument type to allow custom tokens (microsoft#32087) release: applying package updates - react-components [Chore]: Create Spinner base class to abstract out style and layout specific api. (microsoft#32067) [Chore]: Create Progress Bar base class to abstract out style and layout specific api. (microsoft#32066) fix(react-storybook-addon): transform decorator to function in withAriaLive() (microsoft#32011) fix(motion): improve Web Animations API detection in tests (microsoft#32029) chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule (microsoft#32072) release: applying package updates - react v8 release: applying package updates - web-components Chore: Create Divider base class to abstract out style and layout specific api (microsoft#32065) fix(TimePicker): Clear text when date value changes to null (microsoft#31626) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
useAnimateAtoms()checks forwin.Element.prototype.animate. This might cause issues as it's not the same aselement.animate().New Behavior
useAnimateAtoms()checks forelement.animate().Related Issue(s)
Fixes #32025.