Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export drawer and drawer body from root package and package exports #31931

Conversation

chrisdholt
Copy link
Member

Previous Behavior

These were not properly exported

New Behavior

Fixes the export issue

Related Issue(s)

  • Fixes #

@chrisdholt chrisdholt requested a review from a team as a code owner July 5, 2024 19:54
@fabricteam
Copy link
Collaborator

fabricteam commented Jul 5, 2024

📊 Bundle size report

✅ No changes found

@chrisdholt chrisdholt force-pushed the users/chhol/export-drawer-body-and-drawer-properly branch from f905855 to 0f2975d Compare July 8, 2024 15:25
@chrisdholt chrisdholt enabled auto-merge (squash) July 8, 2024 15:26
@chrisdholt chrisdholt merged commit e52adca into microsoft:master Jul 8, 2024
16 of 18 checks passed
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots

Accordion 11 screenshots
Image Name Diff(in Pixels) Image Type
Accordion.Accordion With Custom Icons - RTL.normal.chromium.png 164 Changed
Accordion.Disabled - RTL.normal.chromium.png 33 Changed
Accordion.Size - Dark Mode.normal.chromium.png 2 Changed
Accordion.Size.normal.chromium.png 2 Changed
Accordion.Size - RTL.normal.chromium.png 117 Changed
Accordion.Marker Position End - Dark Mode.normal.chromium.png 0 Added
Accordion.Marker Position End - RTL.normal.chromium.png 0 Added
Accordion.Marker Position End.normal.chromium.png 0 Added
Accordion.Expand Icon Position End - Dark Mode.normal.chromium.png 0 Removed
Accordion.Expand Icon Position End - RTL.normal.chromium.png 0 Removed
Accordion.Expand Icon Position End.normal.chromium.png 0 Removed
Avatar 8 screenshots
Image Name Diff(in Pixels) Image Type
Avatar.Colorful - Dark Mode.normal.chromium.png 452 Changed
Avatar.Colorful - RTL.normal.chromium.png 326 Changed
Avatar.Colorful.normal.chromium.png 325 Changed
Avatar.Active.normal.chromium.png 5 Changed
Avatar.Active Appearance.normal.chromium.png 10 Changed
Avatar.Active Appearance - Dark Mode.normal.chromium.png 2 Changed
Avatar.Color.normal.chromium.png 1 Changed
Avatar.Color - RTL.normal.chromium.png 1 Changed
Badge 6 screenshots
Image Name Diff(in Pixels) Image Type
Badge.Appearance - Dark Mode.normal.chromium.png 15 Changed
Badge.Shape.normal.chromium.png 1 Changed
Badge.Default.normal.chromium.png 1 Changed
Badge.Appearance.normal.chromium.png 1 Changed
Badge.Size.normal.chromium.png 6 Changed
Badge.Color.normal.chromium.png 1 Changed
Button 75 screenshots
Image Name Diff(in Pixels) Image Type
Button.Large Icon Only - Dark Mode.pressed.chromium.png 5 Changed
Button.Large Icon Only - Dark Mode.default.chromium.png 4 Changed
Button.Large Icon Only.hover.chromium.png 4 Changed
Button.Large Icon Only.default.chromium.png 5 Changed
Button.Large Icon Only.pressed.chromium.png 3 Changed
Button.Large With Icon - Dark Mode.pressed.chromium.png 822 Changed
Button.Large With Icon.default.chromium.png 795 Changed
Button.Large With Icon - RTL.hover.chromium.png 761 Changed
Button.Large With Icon - Dark Mode.hover.chromium.png 731 Changed
Button.Large Icon Only - Dark Mode.hover.chromium.png 3 Changed
Button.Large With Icon - RTL.default.chromium.png 795 Changed
Button.Large With Icon - RTL.pressed.chromium.png 707 Changed
Button.Large With Icon.hover.chromium.png 761 Changed
Button.Medium With Icon.default.chromium.png 788 Changed
Button.Medium With Icon - RTL.default.chromium.png 788 Changed
Button.Medium With Icon - RTL.pressed.chromium.png 697 Changed
Button.Medium With Icon - Dark Mode.default.chromium.png 775 Changed
Button.Large With Icon.pressed.chromium.png 707 Changed
Button.Medium With Icon - RTL.hover.chromium.png 753 Changed
Button.Large With Icon - Dark Mode.default.chromium.png 782 Changed
Button.Medium With Icon.hover.chromium.png 753 Changed
Button.Outline Disabled Focusable - Dark Mode.hover.chromium.png 159 Changed
Button.Outline Disabled Focusable - Dark Mode.default.chromium.png 159 Changed
Button.Outline Disabled Focusable - Dark Mode.pressed.chromium.png 159 Changed
Button.Outline Disabled - Dark Mode.hover.chromium.png 159 Changed
Button.Outline Disabled - Dark Mode.pressed.chromium.png 159 Changed
Button.Primary Disabled - Dark Mode.hover.chromium.png 44 Changed
Button.Primary Disabled Focusable - Dark Mode.pressed.chromium.png 44 Changed
Button.Outline Disabled - Dark Mode.default.chromium.png 159 Changed
Button.Medium With Icon - Dark Mode.hover.chromium.png 720 Changed
Button.Primary Disabled Focusable - Dark Mode.default.chromium.png 44 Changed
Button.Medium With Icon.pressed.chromium.png 697 Changed
Button.Primary Disabled Focusable.hover.chromium.png 15 Changed
Button.Primary Disabled - Dark Mode.default.chromium.png 44 Changed
Button.Medium With Icon - Dark Mode.pressed.chromium.png 813 Changed
Button.Primary Disabled.pressed.chromium.png 15 Changed
Button.Primary Disabled Focusable.pressed.chromium.png 15 Changed
Button.Primary Disabled.default.chromium.png 15 Changed
Button.Primary Disabled.hover.chromium.png 15 Changed
Button.Primary Disabled Focusable - Dark Mode.hover.chromium.png 44 Changed
Button.Small With Icon.hover.chromium.png 324 Changed
Button.Small With Icon - Dark Mode.default.chromium.png 334 Changed
Button.Small With Icon - Dark Mode.hover.chromium.png 311 Changed
Button.Small With Icon - RTL.pressed.chromium.png 301 Changed
Button.Subtle Disabled - Dark Mode.default.chromium.png 187 Changed
Button.Subtle Disabled - Dark Mode.pressed.chromium.png 187 Changed
Button.Small With Icon.pressed.chromium.png 301 Changed
Button.Small With Icon - RTL.hover.chromium.png 324 Changed
Button.Primary Disabled - Dark Mode.pressed.chromium.png 44 Changed
Button.Small With Icon - Dark Mode.pressed.chromium.png 351 Changed
Button.Subtle Disabled Focusable - Dark Mode.default.chromium.png 187 Changed
Button.Subtle Disabled.pressed.chromium.png 25 Changed
Button.Primary Disabled Focusable.default.chromium.png 15 Changed
Button.Small With Icon.default.chromium.png 339 Changed
Button.Subtle Disabled - Dark Mode.hover.chromium.png 187 Changed
Button.Small With Icon - RTL.default.chromium.png 339 Changed
Button.Subtle Disabled.default.chromium.png 25 Changed
Button.Subtle Disabled.hover.chromium.png 25 Changed
Button.Subtle Disabled Focusable.hover.chromium.png 25 Changed
Button.Subtle Disabled Focusable.default.chromium.png 25 Changed
Button.Transparent Disabled Focusable.default.chromium.png 27 Changed
Button.Transparent Disabled - Dark Mode.pressed.chromium.png 199 Changed
Button.Transparent Disabled Focusable - Dark Mode.default.chromium.png 199 Changed
Button.Subtle Disabled Focusable.pressed.chromium.png 25 Changed
Button.Subtle Disabled Focusable - Dark Mode.pressed.chromium.png 187 Changed
Button.Subtle Disabled Focusable - Dark Mode.hover.chromium.png 187 Changed
Button.Transparent Disabled - Dark Mode.default.chromium.png 199 Changed
Button.Transparent Disabled.default.chromium.png 27 Changed
Button.Transparent Disabled - Dark Mode.hover.chromium.png 199 Changed
Button.Transparent Disabled Focusable - Dark Mode.pressed.chromium.png 199 Changed
Button.Transparent Disabled Focusable - Dark Mode.hover.chromium.png 199 Changed
Button.Transparent Disabled.hover.chromium.png 27 Changed
Button.Transparent Disabled.pressed.chromium.png 27 Changed
Button.Transparent Disabled Focusable.hover.chromium.png 27 Changed
Button.Transparent Disabled Focusable.pressed.chromium.png 27 Changed
Checkbox 26 screenshots
Image Name Diff(in Pixels) Image Type
Checkbox.Checked.normal.chromium.png 4855 Changed
Checkbox.Circular Checked - Dark Mode.normal.chromium.png 1080 Changed
Checkbox.Circular Checked.normal.chromium.png 4883 Changed
Checkbox.Circular - Dark Mode.normal.chromium.png 792 Changed
Checkbox.Circular Disabled - Dark Mode.normal.chromium.png 760 Changed
Checkbox.Circular Disabled Checked - Dark Mode.normal.chromium.png 799 Changed
Checkbox.Circular Indeterminate - Dark Mode.indeterminate.chromium.png 1102 Changed
Checkbox.Circular Indeterminate - Dark Mode.normal.chromium.png 936 Changed
Checkbox.Circular Indeterminate.normal.chromium.png 4786 Changed
Checkbox.Default - Dark Mode.normal.chromium.png 814 Changed
Checkbox.Disabled Checked.normal.chromium.png 4721 Changed
Checkbox.Indeterminate - Dark Mode.normal.chromium.png 877 Changed
Checkbox.Indeterminate.indeterminate.chromium.png 4847 Changed
Checkbox.Indeterminate.normal.chromium.png 4776 Changed
Checkbox.Circular Disabled Checked.normal.chromium.png 4728 Changed
Checkbox.Circular - RTL.normal.chromium.png 4733 Changed
Checkbox.Circular Disabled.normal.chromium.png 4711 Changed
Checkbox.Indeterminate - Dark Mode.indeterminate.chromium.png 993 Changed
Checkbox.Disabled Checked - Dark Mode.normal.chromium.png 777 Changed
Checkbox.Default - RTL.normal.chromium.png 4751 Changed
Checkbox.Checked - Dark Mode.normal.chromium.png 982 Changed
Checkbox.Disabled.normal.chromium.png 4705 Changed
Checkbox.Circular.normal.chromium.png 4734 Changed
Checkbox.Disabled - Dark Mode.normal.chromium.png 739 Changed
Checkbox.Circular Indeterminate.indeterminate.chromium.png 4869 Changed
Checkbox.Default.normal.chromium.png 4751 Changed
Divider 3 screenshots
Image Name Diff(in Pixels) Image Type
Divider.With Svg.normal.chromium.png 3 Changed
Divider.With Svg - RTL.normal.chromium.png 3 Changed
Divider.Vertical With Svg.normal.chromium.png 4 Changed
Label 2 screenshots
Image Name Diff(in Pixels) Image Type
Label.Required - RTL.normal.chromium.png 11 Changed
Label.Size Small.normal.chromium.png 661 Changed
Link 10 screenshots
Image Name Diff(in Pixels) Image Type
Link.Default.default.chromium.png 0 Added
Link.Default.hover.chromium.png 0 Added
Link.Default.pressed.chromium.png 0 Added
Link.Inline.default.chromium.png 0 Added
Link.Inline.hover.chromium.png 0 Added
Link.Inline.pressed.chromium.png 0 Added
Link.Subtle.default.chromium.png 0 Added
Link.Subtle.hover.chromium.png 0 Added
Link.Subtle.pressed.chromium.png 0 Added
Link.With Long Text.default.chromium.png 0 Added
MenuList 35 screenshots
Image Name Diff(in Pixels) Image Type
MenuList.Checkbox - RTL.1st selected.chromium.png 2 Changed
MenuList.Checkbox - Dark Mode.2nd selected.chromium.png 3 Changed
MenuList.Checkbox - Dark Mode.1st selected.chromium.png 3 Changed
MenuList.Checkbox With Icons.1st selected.chromium.png 5 Changed
MenuList.Checkbox With Icons - RTL.normal.chromium.png 4 Changed
MenuList.Checkbox With Icons - RTL.1st selected.chromium.png 6 Changed
MenuList.Checkbox With Icons.normal.chromium.png 4 Changed
MenuList.Checkbox With Icons - RTL.2nd selected.chromium.png 17 Changed
MenuList.Radio - RTL.2nd selected.chromium.png 2 Changed
MenuList.Radio - Dark Mode.1st selected.chromium.png 3 Changed
MenuList.Radio With Icons - RTL.1st selected.chromium.png 6 Changed
MenuList.Radio With Icons - RTL.2nd selected.chromium.png 17 Changed
MenuList.Radio - RTL.1st selected.chromium.png 2 Changed
MenuList.Checkbox.2nd selected.chromium.png 3 Changed
MenuList.Radio With Icons.2nd selected.chromium.png 17 Changed
MenuList.Checkbox.1st selected.chromium.png 2 Changed
MenuList.Radio.1st selected.chromium.png 2 Changed
MenuList.With Icons.normal.chromium.png 4 Changed
MenuList.Radio With Icons.normal.chromium.png 4 Changed
MenuList.Radio With Icons - RTL.normal.chromium.png 4 Changed
MenuList.Radio - Dark Mode.2nd selected.chromium.png 3 Changed
MenuList.With Icons.hover menuitem.chromium.png 3 Changed
MenuList.With Submenu - RTL.1st selected.chromium.png 706 Changed
MenuList.With Submenu - Dark Mode.1st selected.chromium.png 23 Changed
MenuList.Checkbox With Icons.2nd selected.chromium.png 17 Changed
MenuList.Checkbox - RTL.2nd selected.chromium.png 3 Changed
MenuList.Radio With Icons.1st selected.chromium.png 5 Changed
MenuList.Radio.2nd selected.chromium.png 2 Changed
MenuList.With Submenu - RTL.normal.chromium.png 23 Changed
MenuList.With Submenu - Dark Mode.normal.chromium.png 21 Changed
MenuList.With Submenu.normal.chromium.png 23 Changed
MenuList.With Submenu.1st selected.chromium.png 34 Changed
MenuList.With Submenu - Dark Mode.2nd selected.chromium.png 23 Changed
MenuList.With Submenu - RTL.2nd selected.chromium.png 949 Changed
MenuList.With Submenu.2nd selected.chromium.png 32 Changed
Radio 8 screenshots
Image Name Diff(in Pixels) Image Type
Radio.Default - Dark Mode.normal.chromium.png 595 Changed
Radio.Disabled Checked - Dark Mode.normal.chromium.png 563 Changed
Radio.Disabled.normal.chromium.png 3539 Changed
Radio.Default.normal.chromium.png 3588 Changed
Radio.Checked - Dark Mode.normal.chromium.png 648 Changed
Radio.Disabled Checked.normal.chromium.png 3562 Changed
Radio.Checked.normal.chromium.png 3672 Changed
Radio.Disabled - Dark Mode.normal.chromium.png 545 Changed
RadioGroup 39 screenshots
Image Name Diff(in Pixels) Image Type
RadioGroup.Default - RTL.normal.chromium.png 4699 Changed
RadioGroup.Default Checked.normal.chromium.png 4746 Changed
RadioGroup.Disabled - Dark Mode.normal.chromium.png 821 Changed
RadioGroup.Disabled Item.normal.chromium.png 4695 Changed
RadioGroup.Disabled Item - Dark Mode.normal.chromium.png 939 Changed
RadioGroup.Horizontal Stacked - RTL.normal.chromium.png 11547 Changed
RadioGroup.Vertical.normal.chromium.png 14067 Changed
RadioGroup.Default - Dark Mode.normal.chromium.png 1011 Changed
RadioGroup.Horizontal.normal.chromium.png 4701 Changed
RadioGroup.Horizontal Stacked.normal.chromium.png 11547 Changed
RadioGroup.Default.normal.chromium.png 4701 Changed
RadioGroup.Disabled.normal.chromium.png 4677 Changed
RadioGroup.Vertical - RTL.normal.chromium.png 14067 Changed
RadioGroup.Default - Dark Mode.1st selected.chromium.png 0 Removed
RadioGroup.Default - Dark Mode.2nd selected.chromium.png 0 Removed
RadioGroup.Default - RTL.1st selected.chromium.png 0 Removed
RadioGroup.Default - RTL.2nd selected.chromium.png 0 Removed
RadioGroup.Default Checked.1st selected.chromium.png 0 Removed
RadioGroup.Default Checked.2nd selected.chromium.png 0 Removed
RadioGroup.Default.1st selected.chromium.png 0 Removed
RadioGroup.Default.2nd selected.chromium.png 0 Removed
RadioGroup.Disabled - Dark Mode.1st selected.chromium.png 0 Removed
RadioGroup.Disabled - Dark Mode.2nd selected.chromium.png 0 Removed
RadioGroup.Disabled Item - Dark Mode.1st selected.chromium.png 0 Removed
RadioGroup.Disabled Item - Dark Mode.2nd selected.chromium.png 0 Removed
RadioGroup.Disabled Item.1st selected.chromium.png 0 Removed
RadioGroup.Disabled Item.2nd selected.chromium.png 0 Removed
RadioGroup.Disabled.1st selected.chromium.png 0 Removed
RadioGroup.Disabled.2nd selected.chromium.png 0 Removed
RadioGroup.Horizontal Stacked - RTL.1st selected.chromium.png 0 Removed
RadioGroup.Horizontal Stacked - RTL.2nd selected.chromium.png 0 Removed
RadioGroup.Horizontal Stacked.1st selected.chromium.png 0 Removed
RadioGroup.Horizontal Stacked.2nd selected.chromium.png 0 Removed
RadioGroup.Horizontal.1st selected.chromium.png 0 Removed
RadioGroup.Horizontal.2nd selected.chromium.png 0 Removed
RadioGroup.Vertical - RTL.1st selected.chromium.png 0 Removed
RadioGroup.Vertical - RTL.2nd selected.chromium.png 0 Removed
RadioGroup.Vertical.1st selected.chromium.png 0 Removed
RadioGroup.Vertical.2nd selected.chromium.png 0 Removed
Slider 2 screenshots
Image Name Diff(in Pixels) Image Type
Slider.Size Small.rightArrow.chromium.png 1 Changed
Slider.Size Small.normal.chromium.png 1 Changed
Switch 34 screenshots
Image Name Diff(in Pixels) Image Type
Switch.Checked - RTL.hover.chromium.png 5150 Changed
Switch.Default - RTL.hover.chromium.png 5044 Changed
Switch.Default.hover.chromium.png 5044 Changed
Switch.Checked.hover.chromium.png 5150 Changed
Switch.Checked - Dark Mode.normal.chromium.png 1130 Changed
Switch.Default.normal.chromium.png 5009 Changed
Switch.Disabled - RTL.normal.chromium.png 4914 Changed
Switch.Disabled Checked - Dark Mode.hover.chromium.png 1074 Changed
Switch.Default - RTL.normal.chromium.png 5009 Changed
Switch.Default - Dark Mode.normal.chromium.png 1019 Changed
Switch.Default - Dark Mode.hover.chromium.png 1071 Changed
Switch.Disabled Checked.hover.chromium.png 5047 Changed
Switch.Disabled Checked.normal.chromium.png 5047 Changed
Switch.Disabled Checked - Dark Mode.normal.chromium.png 1074 Changed
Switch.Checked - Dark Mode.hover.chromium.png 1169 Changed
Switch.Disabled - Dark Mode.hover.chromium.png 909 Changed
Switch.Checked.normal.chromium.png 5132 Changed
Switch.Checked - RTL.normal.chromium.png 5132 Changed
Switch.Disabled - RTL.hover.chromium.png 4914 Changed
Switch.Disabled - Dark Mode.normal.chromium.png 909 Changed
Switch.Disabled.normal.chromium.png 4914 Changed
Switch.Disabled.hover.chromium.png 4914 Changed
Switch.Label Above - RTL.hover.chromium.png 0 Removed
Switch.Label Above - RTL.normal.chromium.png 0 Removed
Switch.Label Above.hover.chromium.png 0 Removed
Switch.Label Above.normal.chromium.png 0 Removed
Switch.Label After - RTL.hover.chromium.png 0 Removed
Switch.Label After - RTL.normal.chromium.png 0 Removed
Switch.Label After.hover.chromium.png 0 Removed
Switch.Label After.normal.chromium.png 0 Removed
Switch.Label Before - RTL.hover.chromium.png 0 Removed
Switch.Label Before - RTL.normal.chromium.png 0 Removed
Switch.Label Before.hover.chromium.png 0 Removed
Switch.Label Before.normal.chromium.png 0 Removed
Text 1 screenshots
Image Name Diff(in Pixels) Image Type
Text.Block.normal.chromium.png 958 Changed
TextInput 4 screenshots
Image Name Diff(in Pixels) Image Type
TextInput.Content Start End - Dark Mode.normal.chromium.png 102 Changed
TextInput.Content Start End - RTL.normal.chromium.png 119 Changed
TextInput.Content Start End.normal.chromium.png 116 Changed
TextInput.Size Large.normal.chromium.png 3 Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants