feat: update spinner to use Element Internals for presentational styling #31741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Jun 17, 2024
change/@fluentui-web-components-d43a8b52-e22f-4523-af8b-a42fd90a4765.json
Show resolved
Hide resolved
janechu
approved these changes
Jun 18, 2024
davatron5000
approved these changes
Jun 18, 2024
chrisdholt
force-pushed
the
users/chhol/update-spinner-with-custom-states
branch
from
9c66a70 to
41514d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR updates the spinner to use Element Internals custom states for presentational styling with an attribute fallback where not available.
Related Issue(s)