High Contrast Checkbox Web Component fix #31157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
procload
changed the title
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Apr 23, 2024
change/@fluentui-web-components-2f7edf54-0877-419b-8a74-47bf7c3681f8.json
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
procload
changed the title
radium-v
force-pushed
the
web-components-v3
branch
from
3287714 to
3d89250
Compare
procload
requested review from
a team,
GeoffCoxMSFT,
marcosmoura,
sopranopillow,
tomi-msft,
micahgodbolt,
smhigley,
behowell,
spmonahan,
khmakoto,
dzearing,
Jacqueline-ms,
robtaft-ms,
Hirse and
JustSlone
as code owners
|
@chrisdholt Thanks for the review. Feedback addressed by updating the selectors to use |
chrisdholt
removed request for
a team,
dzearing,
marcosmoura,
micahgodbolt,
Hirse,
robtaft-ms,
smhigley,
sopranopillow,
khmakoto,
jurokapsiar,
GeoffCoxMSFT,
Jacqueline-ms,
JustSlone,
behowell,
tomi-msft,
spmonahan and
tudorpopams
|
@chrisdholt Did you have any other feedback on this, or can we merge this? |
The DOM is changing quite a bit in #31468 and I believe that should be updated for High Contrast. We may just want to defer to the checkbox refactor PR for this to be resolved. @radium-v can advise on how close we are there (I think it's right there...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
High contrast styles for the checkbox were missing for the disabled state and mixed, indeterminate states:
New Behavior
Adds specific colors, backgrounds, and border colors for high contrast disabled and checked/mixed states:
