fix(web-components): refactor exports to remove most barrel exports for components #31069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against c07bf2bf7906b7595aaacdeb48255acb8781201b |
fabricteam
reviewed
Apr 16, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Slider 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Slider.Slider Steps.normal.chromium.png | 1 | Changed |
| Slider.Slider Steps Vertical.normal.chromium.png | 1 | Changed |
Text 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Text.Block.normal.chromium.png | 995 | Changed |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
mohamedmansour
approved these changes
Apr 16, 2024
eljefe223
approved these changes
Apr 16, 2024
chrisdholt
force-pushed
the
users/chhol/remove-barrel-exports-for-main-bundle
branch
2 times, most recently
from
95cc713 to
72f0c36
Compare
chrisdholt
commented
Apr 25, 2024
change/@fluentui-web-components-b79350c6-45b4-4047-b3cb-bdd2f3913561.json
Show resolved
Hide resolved
chrisdholt
force-pushed
the
users/chhol/remove-barrel-exports-for-main-bundle
branch
from
cc2b31d to
9b2f020
Compare
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
…or components (#31069) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…or components (#31069) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…or components (#31069) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
…or components (#31069) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
…or components (#31069) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…or components (#31069) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
…or components (#31069) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
…or components (#31069) Co-authored-by: Christopher Holt <=>
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
…or components (#31069) Co-authored-by: Christopher Holt <=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
All components are exported from the main bundle via barrel exports which can create problems for modern compilers.
New Behavior
All exports but design tokens have been moved away from barrel exports. I'm holding on the design token export simply as it doesn't have any clear side effectful issues and currently when setting theme there isn't a good way to tree shake what isn't used. That work is likely to follow.
Related Issue(s)