add compound button as new v3 component #27407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against b3e854454d0d192a1af7ac79602213f53f2873ca |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b3e854454d0d192a1af7ac79602213f53f2873ca (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d234061:
|
eljefe223
reviewed
Mar 31, 2023
packages/web-components/src/compound-button/compound-button.styles.ts
Outdated
Show resolved
Hide resolved
eljefe223
reviewed
Mar 31, 2023
packages/web-components/src/compound-button/compound-button.styles.ts
Outdated
Show resolved
Hide resolved
eljefe223
reviewed
Mar 31, 2023
packages/web-components/src/compound-button/compound-button.styles.ts
Outdated
Show resolved
Hide resolved
eljefe223
approved these changes
Mar 31, 2023
eljefe223
approved these changes
Apr 3, 2023
chrisdholt
force-pushed
the
users/chhol/add-compound-button-as-new-v3-component
branch
from
28dae15 to
845f5e7
Compare
eljefe223
reviewed
Apr 5, 2023
packages/web-components/src/compound-button/compound-button.stories.ts
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| :host ::slotted(svg), | ||
| :host([size='large']) ::slotted(svg) { |
There was a problem hiding this comment.
Maybe it is just me, but the two selectors and !importants are difficult to understand. It would be great if we could be adding comments for complex selectors.
There was a problem hiding this comment.
Important wasn't necessary here
miroslavstastny
approved these changes
Apr 10, 2023
chrisdholt
force-pushed
the
users/chhol/add-compound-button-as-new-v3-component
branch
from
66d2d64 to
d234061
Compare
chrisdholt
added a commit
that referenced
this pull request
Apr 29, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* add compound button as a new web component * change files * update locc css * remove icon ref in stories * remove icon attr in stories and address vertical alignment of buttons * fix disabled primary styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Related Issue(s)