chore: Enable Typescript strict mode #26950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
commented
Feb 23, 2023
| import { CounterBadge } from './counter-badge.js'; | ||
| import { CounterBadgeOptions } from './counter-badge.options.js'; | ||
|
|
||
| function composeTemplate<T extends CounterBadge>(options: CounterBadgeOptions = {}): ElementViewTemplate<T> { | ||
| return badgeTemplate({ | ||
| function composeTemplate<T extends CounterBadge & Badge>(options: CounterBadgeOptions = {}): ElementViewTemplate<T> { |
There was a problem hiding this comment.
CounterBadge composes Badge template but does not inherit from it.
@chrisdholt Are you OK with this change or would you propose a different fix?
There was a problem hiding this comment.
Let's leave it for now and see how it goes
📊 Bundle size reportUnchanged fixtures
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
micahgodbolt
approved these changes
Feb 23, 2023
chrisdholt
approved these changes
Feb 23, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 688ab816b7c0c345d764a993fafe27dfe4a73da5 (build) |
miroslavstastny
force-pushed
the
chore/typescript-strict
branch
from
04bc405 to
b4ada6e
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7e2ee4d:
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
miroslavstastny
force-pushed
the
chore/typescript-strict
branch
from
c6cb97f to
7e2ee4d
Compare
1 task
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* chore: Enable Typescript strict mode * change file * revert unnecessary change * update api-report after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables Typescript strict mode for Web Components v3.
Fixes #26891