-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Fluent Image web component #26622
Adds Fluent Image web component #26622
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6fda249:
|
@chrisdholt Updated code. I removed |
📊 Bundle size report🤖 This report was generated against 1ad2597f744bf7c3e2eada7720eea793fcee660e |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1ad2597f744bf7c3e2eada7720eea793fcee660e (build) |
…les of image fit: center, cover, contain.
…ves custom properties off the image element and onto the host.
* update fast element and foundation versions and update reference to extend badge options * no options export yet for badge :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but I'd like to make sure that @miroslavstastny has a chance to confirm he's good with this, and a couple of things to clean up.
…les of image fit: center, cover, contain.
…ves custom properties off the image element and onto the host.
….com/halerankin/fluentui into dev/harankin/fluentImageWebComponent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR currently contains invalid changes, perhaps caused by merge/rebase.
@miroslavstastny I will open a new PR with only my changes. |
Adds Image web component.