Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Fluent Image web component #26622

Closed
wants to merge 37 commits into from
Closed

Adds Fluent Image web component #26622

wants to merge 37 commits into from

Conversation

halerankin
Copy link
Contributor

Adds Image web component.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6fda249:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@halerankin
Copy link
Contributor Author

@chrisdholt Updated code. I removed alt, role and src from the component as they are already native attributes on the img element. I removed the block attribute because the same results can be achieved by setting fit to contain. I removed margin attribute based on our conversation. I updated the args table to show that these can all be supplied by the component consumer.

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 13, 2023

📊 Bundle size report

🤖 This report was generated against 1ad2597f744bf7c3e2eada7720eea793fcee660e

@size-auditor
Copy link

size-auditor bot commented Feb 13, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 1ad2597f744bf7c3e2eada7720eea793fcee660e (build)

Copy link
Member

@chrisdholt chrisdholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I'd like to make sure that @miroslavstastny has a chance to confirm he's good with this, and a couple of things to clean up.

@halerankin halerankin requested a review from a team as a code owner February 17, 2023 21:07
Copy link
Member

@miroslavstastny miroslavstastny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR currently contains invalid changes, perhaps caused by merge/rebase.

@halerankin
Copy link
Contributor Author

@miroslavstastny I will open a new PR with only my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants