fix: Portal compat should apply focus-visible ponyfill
#24712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@fluentui/react-portal-compat` now takes a dependency on `@fluentui/react-tabster` to apply the `focus-vislble` ponyfill. Also setup e2e tests for the portal compat package to test that the ponyfill is correctly applied.
📊 Bundle size report
Unchanged fixtures
|
bsunderhus
approved these changes
Sep 8, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 263e12a:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e4d50f2c501c4a8be23b24373242f650a601fdaf (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1604 | 1635 | 5000 | |
| Button | mount | 1174 | 1185 | 5000 | |
| FluentProvider | mount | 1992 | 1949 | 5000 | |
| FluentProviderWithTheme | mount | 803 | 801 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 726 | 722 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 800 | 772 | 10 | |
| MakeStyles | mount | 2392 | 2324 | 50000 | |
| SpinButton | mount | 3105 | 3102 | 5000 |
|
@ling1726 Can you please add a bundle size fixture to see how it affects bundle size? |
Added in 263e12a The minified size is ~5kb. I looked into the output and the extra code is keyborg + the ponyfill itself. It should be fine since if users are using the |
layershifter
approved these changes
Sep 8, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 9, 2022
* master: (63 commits) feat: add helper types to assist DOM element handling (microsoft#24722) applying package updates Textarea/hc bug (microsoft#24701) Fix null ref in use slider (microsoft#24728) Add Field unit tests, and remove snapshot tests (microsoft#24706) Stress Test: add build commands (microsoft#24575) Coachmark - useOffsetHeight should cause re-render on each set state to match v7 functionality (microsoft#24702) Implement screener tests for Field components (microsoft#24684) Update Field types to clean up react-field.api.md (microsoft#24703) fix(Popup): remove rotate(360deg) from PopupContent content styles (microsoft#24432) fix(FocusZone): should reset tabindex when focus is outside the zone with prop `shouldResetActiveElementWhenTabFromZone` (microsoft#24463) Fix greyed out legend key contrast ratio (microsoft#24714) fix: Portal compat should apply `focus-visible` ponyfill (microsoft#24712) Fix artifact error (microsoft#24717) chore(react-dialog): remove localShorthands in favor of griffel shorthands (microsoft#24715) Skip screener checks for draft PRs with exception of appropriately la… (microsoft#24694) fix: Remove provider classname from focus styles (microsoft#24710) feat: autocontrolled `useTable` hook (microsoft#24688) feat: add dialog properties to getNativeElementProps (microsoft#24698) Using migrate rather than upgrade term (microsoft#24695) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fluentui/react-portal-compatnow takes a dependency on@fluentui/react-tabsterto apply thefocus-vislbleponyfill. Also setup e2e tests for the portal compat package to test that the ponyfill is correctly applied.Current Behavior
Portal compat will not apply v9 focus outline styles
New Behavior
Portal compat will apply v9 focus outline styles
Related Issue(s)
Fixes #24411