-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backspace does not work in BaseExtendedPicker in projection popout windows #19738
Backspace does not work in BaseExtendedPicker in projection popout windows #19738
Conversation
📊 Bundle size report🤖 This report was generated against 9fcb642d0a1947d85e81dc2db9a9d51816b7a3ae |
Asset size changes
Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B Baseline commit: 9fcb642d0a1947d85e81dc2db9a9d51816b7a3ae (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 634d3ed:
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Panel | mount | 2385 | 1391 | 1000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 900 | 926 | 5000 | |
BaseButton | mount | 891 | 897 | 5000 | |
Breadcrumb | mount | 2650 | 2662 | 1000 | |
ButtonNext | mount | 459 | 450 | 5000 | |
Checkbox | mount | 1537 | 1507 | 5000 | |
CheckboxBase | mount | 1330 | 1291 | 5000 | |
ChoiceGroup | mount | 4763 | 4859 | 5000 | |
ComboBox | mount | 1019 | 993 | 1000 | |
CommandBar | mount | 10367 | 10387 | 1000 | |
ContextualMenu | mount | 6610 | 6669 | 1000 | |
DefaultButton | mount | 1158 | 1145 | 5000 | |
DetailsRow | mount | 3796 | 3791 | 5000 | |
DetailsRowFast | mount | 3761 | 3810 | 5000 | |
DetailsRowNoStyles | mount | 3541 | 3575 | 5000 | |
Dialog | mount | 2439 | 2443 | 1000 | |
DocumentCardTitle | mount | 154 | 136 | 1000 | |
Dropdown | mount | 3262 | 3290 | 5000 | |
FluentProviderNext | mount | 7432 | 7539 | 5000 | |
FluentProviderWithTheme | mount | 349 | 369 | 10 | |
FluentProviderWithTheme | virtual-rerender | 100 | 90 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 479 | 471 | 10 | |
FocusTrapZone | mount | 1812 | 1799 | 5000 | |
FocusZone | mount | 1859 | 1936 | 5000 | |
IconButton | mount | 1761 | 1796 | 5000 | |
Label | mount | 335 | 335 | 5000 | |
Layer | mount | 3045 | 3001 | 5000 | |
Link | mount | 481 | 477 | 5000 | |
MakeStyles | mount | 1808 | 1894 | 50000 | |
MenuButton | mount | 1478 | 1464 | 5000 | |
MessageBar | mount | 2038 | 2015 | 5000 | |
Nav | mount | 3323 | 3326 | 1000 | |
OverflowSet | mount | 1114 | 1126 | 5000 | |
Panel | mount | 2385 | 1391 | 1000 | Possible regression |
Persona | mount | 857 | 853 | 1000 | |
Pivot | mount | 1478 | 1429 | 1000 | |
PrimaryButton | mount | 1287 | 1270 | 5000 | |
Rating | mount | 7748 | 7732 | 5000 | |
SearchBox | mount | 1378 | 1326 | 5000 | |
Shimmer | mount | 2513 | 2533 | 5000 | |
Slider | mount | 1988 | 2043 | 5000 | |
SpinButton | mount | 5095 | 5070 | 5000 | |
Spinner | mount | 438 | 436 | 5000 | |
SplitButton | mount | 3248 | 3195 | 5000 | |
Stack | mount | 489 | 487 | 5000 | |
StackWithIntrinsicChildren | mount | 1646 | 1657 | 5000 | |
StackWithTextChildren | mount | 4664 | 4580 | 5000 | |
SwatchColorPicker | mount | 10563 | 10483 | 5000 | |
Tabs | mount | 1448 | 1427 | 1000 | |
TagPicker | mount | 2643 | 2683 | 5000 | |
TeachingBubble | mount | 13572 | 13447 | 5000 | |
Text | mount | 426 | 424 | 5000 | |
TextField | mount | 1402 | 1407 | 5000 | |
ThemeProvider | mount | 1205 | 1210 | 5000 | |
ThemeProvider | virtual-rerender | 597 | 599 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1911 | 1910 | 5000 | |
Toggle | mount | 816 | 827 | 5000 | |
buttonNative | mount | 117 | 115 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ButtonMinimalPerf.default | 182 | 166 | 1.1:1 |
ReactionMinimalPerf.default | 396 | 366 | 1.08:1 |
ChatDuplicateMessagesPerf.default | 306 | 292 | 1.05:1 |
IconMinimalPerf.default | 637 | 606 | 1.05:1 |
AttachmentSlotsPerf.default | 1108 | 1067 | 1.04:1 |
ButtonSlotsPerf.default | 565 | 541 | 1.04:1 |
FlexMinimalPerf.default | 295 | 284 | 1.04:1 |
AttachmentMinimalPerf.default | 164 | 159 | 1.03:1 |
CardMinimalPerf.default | 566 | 549 | 1.03:1 |
ChatWithPopoverPerf.default | 382 | 372 | 1.03:1 |
DialogMinimalPerf.default | 775 | 756 | 1.03:1 |
HeaderMinimalPerf.default | 367 | 358 | 1.03:1 |
ImageMinimalPerf.default | 373 | 362 | 1.03:1 |
InputMinimalPerf.default | 1344 | 1301 | 1.03:1 |
ListMinimalPerf.default | 522 | 509 | 1.03:1 |
ListWith60ListItems.default | 652 | 634 | 1.03:1 |
PopupMinimalPerf.default | 611 | 594 | 1.03:1 |
RadioGroupMinimalPerf.default | 458 | 444 | 1.03:1 |
SliderMinimalPerf.default | 1671 | 1619 | 1.03:1 |
AccordionMinimalPerf.default | 156 | 153 | 1.02:1 |
AvatarMinimalPerf.default | 196 | 192 | 1.02:1 |
ButtonOverridesMissPerf.default | 1768 | 1739 | 1.02:1 |
DropdownManyItemsPerf.default | 687 | 671 | 1.02:1 |
GridMinimalPerf.default | 358 | 352 | 1.02:1 |
SplitButtonMinimalPerf.default | 4236 | 4173 | 1.02:1 |
StatusMinimalPerf.default | 673 | 658 | 1.02:1 |
TableMinimalPerf.default | 410 | 401 | 1.02:1 |
ToolbarMinimalPerf.default | 977 | 954 | 1.02:1 |
TreeWith60ListItems.default | 182 | 179 | 1.02:1 |
BoxMinimalPerf.default | 350 | 348 | 1.01:1 |
DividerMinimalPerf.default | 366 | 363 | 1.01:1 |
DropdownMinimalPerf.default | 3218 | 3186 | 1.01:1 |
HeaderSlotsPerf.default | 755 | 746 | 1.01:1 |
ItemLayoutMinimalPerf.default | 1223 | 1208 | 1.01:1 |
LayoutMinimalPerf.default | 364 | 359 | 1.01:1 |
ListNestedPerf.default | 552 | 548 | 1.01:1 |
LoaderMinimalPerf.default | 702 | 693 | 1.01:1 |
ProviderMinimalPerf.default | 1088 | 1081 | 1.01:1 |
SkeletonMinimalPerf.default | 351 | 348 | 1.01:1 |
TextAreaMinimalPerf.default | 501 | 498 | 1.01:1 |
CustomToolbarPrototype.default | 4085 | 4045 | 1.01:1 |
AnimationMinimalPerf.default | 401 | 400 | 1:1 |
ChatMinimalPerf.default | 646 | 644 | 1:1 |
CheckboxMinimalPerf.default | 2758 | 2764 | 1:1 |
MenuMinimalPerf.default | 845 | 843 | 1:1 |
ProviderMergeThemesPerf.default | 1715 | 1709 | 1:1 |
SegmentMinimalPerf.default | 352 | 351 | 1:1 |
TableManyItemsPerf.default | 1938 | 1938 | 1:1 |
TextMinimalPerf.default | 344 | 344 | 1:1 |
TooltipMinimalPerf.default | 1035 | 1039 | 1:1 |
AlertMinimalPerf.default | 269 | 272 | 0.99:1 |
CarouselMinimalPerf.default | 475 | 482 | 0.99:1 |
DatepickerMinimalPerf.default | 5494 | 5531 | 0.99:1 |
EmbedMinimalPerf.default | 4250 | 4278 | 0.99:1 |
ListCommonPerf.default | 620 | 626 | 0.99:1 |
RefMinimalPerf.default | 233 | 235 | 0.99:1 |
VideoMinimalPerf.default | 596 | 599 | 0.99:1 |
MenuButtonMinimalPerf.default | 1647 | 1673 | 0.98:1 |
TreeMinimalPerf.default | 800 | 817 | 0.98:1 |
PortalMinimalPerf.default | 180 | 186 | 0.97:1 |
LabelMinimalPerf.default | 373 | 388 | 0.96:1 |
FormMinimalPerf.default | 406 | 429 | 0.95:1 |
RosterPerf.default | 1136 | 1200 | 0.95:1 |
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Pull request checklist
$ yarn change
Description of changes
In a popout window, users cannot use backspace to remove recipients. This is similar to this issue that was fixed a couple of months ago. This is another component that needs this fix
Focus areas to test
(optional)