Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-components] add definition files for Fluent UI Web Components #18961

Conversation

chrisdholt
Copy link
Member

Pull request checklist

Description of changes

Adds definition files for Fluent UI web components

Focus areas to test

(optional)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 445c04ac55f894b8265a38ddf31ff83979ba3854

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bf1eef:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 15, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7ca92e78f37a4e5bb41696d0c9b53b8388e82000 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 847 831 5000
BaseButton mount 961 964 5000
Breadcrumb mount 2654 2593 1000
ButtonNext mount 577 523 5000
Checkbox mount 1546 1601 5000
CheckboxBase mount 1346 1377 5000
ChoiceGroup mount 4820 4852 5000
ComboBox mount 977 957 1000
CommandBar mount 10055 10032 1000
ContextualMenu mount 6351 6221 1000
DefaultButton mount 1218 1180 5000
DetailsRow mount 3858 3890 5000
DetailsRowFast mount 3797 3827 5000
DetailsRowNoStyles mount 3654 3705 5000
Dialog mount 2213 2265 1000
DocumentCardTitle mount 148 149 1000
Dropdown mount 3419 3402 5000
FluentProviderNext mount 6796 6895 5000
FocusTrapZone mount 1774 1804 5000
FocusZone mount 1788 1846 5000
IconButton mount 1825 1878 5000
Label mount 341 349 5000
Layer mount 1911 1814 5000
Link mount 482 467 5000
MakeStyles mount 1820 1818 50000
MenuButton mount 1563 1577 5000
MessageBar mount 2009 2015 5000
Nav mount 3382 3367 1000
OverflowSet mount 1071 1064 5000
Panel mount 2154 2111 1000
Persona mount 855 828 1000
Pivot mount 1465 1496 1000
PrimaryButton mount 1378 1339 5000
Rating mount 8022 8122 5000
SearchBox mount 1369 1374 5000
Shimmer mount 2727 2683 5000
Slider mount 2082 2016 5000
SpinButton mount 5119 5172 5000
Spinner mount 410 413 5000
SplitButton mount 3230 3262 5000
Stack mount 519 518 5000
StackWithIntrinsicChildren mount 1587 1605 5000
StackWithTextChildren mount 4711 4746 5000
SwatchColorPicker mount 10350 10384 5000
Tabs mount 1430 1426 1000
TagPicker mount 2480 2456 5000
TeachingBubble mount 11768 11708 5000
Text mount 451 428 5000
TextField mount 1443 1401 5000
ThemeProvider mount 1168 1155 5000
ThemeProvider virtual-rerender 589 600 5000
Toggle mount 799 817 5000
buttonNative mount 118 112 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 321 284 1.13:1
LabelMinimalPerf.default 429 381 1.13:1
TreeWith60ListItems.default 193 179 1.08:1
BoxMinimalPerf.default 388 361 1.07:1
SegmentMinimalPerf.default 375 351 1.07:1
AttachmentMinimalPerf.default 171 161 1.06:1
ButtonMinimalPerf.default 190 179 1.06:1
DropdownManyItemsPerf.default 750 706 1.06:1
HeaderMinimalPerf.default 398 375 1.06:1
ListNestedPerf.default 607 573 1.06:1
PopupMinimalPerf.default 635 601 1.06:1
TableMinimalPerf.default 440 417 1.06:1
ChatDuplicateMessagesPerf.default 325 311 1.05:1
LoaderMinimalPerf.default 740 703 1.05:1
PortalMinimalPerf.default 179 170 1.05:1
RadioGroupMinimalPerf.default 496 472 1.05:1
RefMinimalPerf.default 246 235 1.05:1
CardMinimalPerf.default 582 562 1.04:1
CarouselMinimalPerf.default 486 468 1.04:1
ChatMinimalPerf.default 702 672 1.04:1
ItemLayoutMinimalPerf.default 1322 1274 1.04:1
MenuButtonMinimalPerf.default 1748 1686 1.04:1
SplitButtonMinimalPerf.default 4089 3949 1.04:1
ToolbarMinimalPerf.default 1030 988 1.04:1
DatepickerMinimalPerf.default 5652 5465 1.03:1
ImageMinimalPerf.default 404 393 1.03:1
TableManyItemsPerf.default 2078 2015 1.03:1
AccordionMinimalPerf.default 155 152 1.02:1
EmbedMinimalPerf.default 4296 4200 1.02:1
SliderMinimalPerf.default 1627 1602 1.02:1
StatusMinimalPerf.default 741 730 1.02:1
IconMinimalPerf.default 637 623 1.02:1
TextMinimalPerf.default 378 370 1.02:1
AttachmentSlotsPerf.default 1109 1100 1.01:1
ButtonOverridesMissPerf.default 1764 1746 1.01:1
DividerMinimalPerf.default 397 394 1.01:1
GridMinimalPerf.default 371 367 1.01:1
LayoutMinimalPerf.default 383 381 1.01:1
ProviderMergeThemesPerf.default 1628 1614 1.01:1
ProviderMinimalPerf.default 1041 1026 1.01:1
CustomToolbarPrototype.default 4000 3973 1.01:1
TooltipMinimalPerf.default 1054 1044 1.01:1
TreeMinimalPerf.default 820 810 1.01:1
AlertMinimalPerf.default 278 278 1:1
AnimationMinimalPerf.default 415 414 1:1
CheckboxMinimalPerf.default 2785 2796 1:1
InputMinimalPerf.default 1294 1298 1:1
ListCommonPerf.default 677 680 1:1
AvatarMinimalPerf.default 197 200 0.99:1
ChatWithPopoverPerf.default 378 383 0.99:1
DialogMinimalPerf.default 795 801 0.99:1
HeaderSlotsPerf.default 807 819 0.99:1
ListWith60ListItems.default 663 670 0.99:1
MenuMinimalPerf.default 879 889 0.99:1
SkeletonMinimalPerf.default 373 375 0.99:1
TextAreaMinimalPerf.default 536 540 0.99:1
VideoMinimalPerf.default 668 675 0.99:1
ButtonSlotsPerf.default 582 595 0.98:1
DropdownMinimalPerf.default 3121 3179 0.98:1
FormMinimalPerf.default 454 469 0.97:1
RosterPerf.default 1263 1297 0.97:1
ListMinimalPerf.default 545 565 0.96:1
ReactionMinimalPerf.default 407 427 0.95:1

@chrisdholt chrisdholt merged commit f5120ce into microsoft:master Jul 15, 2021
@chrisdholt chrisdholt deleted the users/chhol/add-definition-files-for-fluent-ui-wc branch July 15, 2021 21:12
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v1.2.0 has been released which incorporates this pull request.:tada:

Handy links:

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
…icrosoft#18961)

* create and export web component definitions for use with Monaco editor tooling

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create definition files for Fluent UI web components
5 participants