Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing file export for web-components parseColorString method #16876

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Fixes an issue where a file was not being exported as expected.

Focus areas to test

(optional)

@@ -0,0 +1,7 @@
{
"type": "patch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "patch",
"type": "minor",

since it contains api change?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dcd43c3:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 8, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 0f46d91d5de073dc025dc8a137a8caa2eda21a08 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 8, 2021

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 821 818 5000
BaseButtonCompat mount 898 882 5000
Breadcrumb mount 43491 43325 5000
Checkbox mount 1465 1470 5000
CheckboxBase mount 1207 1258 5000
ChoiceGroup mount 4761 4657 5000
ComboBox mount 985 934 1000
CommandBar mount 10205 10138 1000
ContextualMenu mount 6055 6143 1000
DefaultButtonCompat mount 1122 1113 5000
DetailsRow mount 3629 3589 5000
DetailsRowFast mount 3669 3575 5000
DetailsRowNoStyles mount 3434 3344 5000
Dialog mount 1431 1453 1000
DocumentCardTitle mount 1854 1844 1000
Dropdown mount 3238 3289 5000
FocusTrapZone mount 1759 1823 5000
FocusZone mount 1821 1780 5000
IconButtonCompat mount 1716 1709 5000
Label mount 328 340 5000
Layer mount 1773 1794 5000
Link mount 454 458 5000
MakeStyles mount 1969 1970 50000
MenuButtonCompat mount 1464 1455 5000
MessageBar mount 2020 2018 5000
Nav mount 3326 3208 1000
OverflowSet mount 1030 1061 5000
Panel mount 1357 1408 1000
Persona mount 819 846 1000
Pivot mount 1406 1394 1000
PrimaryButtonCompat mount 1248 1278 5000
Rating mount 7417 7457 5000
SearchBox mount 1269 1284 5000
Shimmer mount 2487 2502 5000
Slider mount 1874 1871 5000
SpinButton mount 4977 5119 5000
Spinner mount 427 423 5000
SplitButtonCompat mount 3090 3151 5000
Stack mount 486 499 5000
StackWithIntrinsicChildren mount 1525 1562 5000
StackWithTextChildren mount 4482 4463 5000
SwatchColorPicker mount 10275 10184 5000
Tabs mount 1417 1399 1000
TagPicker mount 2746 2723 5000
TeachingBubble mount 11606 11574 5000
Text mount 396 413 5000
TextField mount 1338 1355 5000
ThemeProvider mount 1389 1417 5000
ThemeProvider virtual-rerender 598 597 5000
ThemeProviderNext mount 2189 2196 5000
Toggle mount 794 794 5000
button mount 660 654 5000
buttonNative mount 109 123 5000

Perf Analysis (Fluent)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 180 190 0.95:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.18 0.51 0.35:1 2000 353
🦄 Button.Fluent 0.11 0.2 0.55:1 5000 570
🔧 Checkbox.Fluent 0.65 0.36 1.81:1 1000 645
🎯 Dialog.Fluent 0.16 0.21 0.76:1 5000 802
🔧 Dropdown.Fluent 3.15 0.41 7.68:1 1000 3153
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 705
🦄 Image.Fluent 0.08 0.13 0.62:1 5000 405
🔧 Slider.Fluent 1.63 0.45 3.62:1 1000 1626
🔧 Text.Fluent 0.08 0.04 2:1 5000 387
🦄 Tooltip.Fluent 0.12 0.88 0.14:1 5000 589

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatWithPopoverPerf.default 478 438 1.09:1
RefMinimalPerf.default 263 248 1.06:1
Text.Fluent 387 366 1.06:1
AttachmentMinimalPerf.default 178 170 1.05:1
TextAreaMinimalPerf.default 518 491 1.05:1
LabelMinimalPerf.default 455 436 1.04:1
PortalMinimalPerf.default 174 167 1.04:1
SegmentMinimalPerf.default 378 365 1.04:1
Icon.Fluent 705 681 1.04:1
CarouselMinimalPerf.default 497 484 1.03:1
ChatMinimalPerf.default 638 618 1.03:1
GridMinimalPerf.default 376 365 1.03:1
ToolbarMinimalPerf.default 992 965 1.03:1
Avatar.Fluent 353 344 1.03:1
AlertMinimalPerf.default 312 305 1.02:1
ButtonUseCssNestingPerf.default 1110 1089 1.02:1
ImageMinimalPerf.default 395 389 1.02:1
ListCommonPerf.default 667 651 1.02:1
CustomToolbarPrototype.default 3875 3816 1.02:1
TreeMinimalPerf.default 808 793 1.02:1
Image.Fluent 405 396 1.02:1
AvatarMinimalPerf.default 213 211 1.01:1
ButtonOverridesMissPerf.default 1739 1730 1.01:1
DatepickerMinimalPerf.default 46915 46437 1.01:1
DialogMinimalPerf.default 808 803 1.01:1
FlexMinimalPerf.default 319 317 1.01:1
HeaderSlotsPerf.default 819 811 1.01:1
ListMinimalPerf.default 527 523 1.01:1
PopupMinimalPerf.default 728 719 1.01:1
SkeletonMinimalPerf.default 386 382 1.01:1
TableManyItemsPerf.default 2065 2039 1.01:1
TableMinimalPerf.default 431 425 1.01:1
Dropdown.Fluent 3153 3134 1.01:1
AnimationMinimalPerf.default 417 419 1:1
BoxMinimalPerf.default 379 378 1:1
ButtonUseCssPerf.default 842 844 1:1
CheckboxMinimalPerf.default 2868 2878 1:1
DropdownMinimalPerf.default 3129 3137 1:1
EmbedMinimalPerf.default 4305 4284 1:1
InputMinimalPerf.default 1318 1321 1:1
ListNestedPerf.default 584 582 1:1
LoaderMinimalPerf.default 750 753 1:1
MenuMinimalPerf.default 914 914 1:1
ProviderMergeThemesPerf.default 1644 1645 1:1
ProviderMinimalPerf.default 992 996 1:1
ReactionMinimalPerf.default 418 417 1:1
SplitButtonMinimalPerf.default 3803 3790 1:1
TooltipMinimalPerf.default 834 830 1:1
VideoMinimalPerf.default 653 651 1:1
Checkbox.Fluent 645 643 1:1
Dialog.Fluent 802 803 1:1
AttachmentSlotsPerf.default 1212 1223 0.99:1
ButtonSlotsPerf.default 595 603 0.99:1
DividerMinimalPerf.default 381 386 0.99:1
DropdownManyItemsPerf.default 728 737 0.99:1
HeaderMinimalPerf.default 389 392 0.99:1
ItemLayoutMinimalPerf.default 1246 1262 0.99:1
LayoutMinimalPerf.default 425 428 0.99:1
MenuButtonMinimalPerf.default 1590 1606 0.99:1
SliderMinimalPerf.default 1626 1639 0.99:1
StatusMinimalPerf.default 743 747 0.99:1
Button.Fluent 570 574 0.99:1
Slider.Fluent 1626 1639 0.99:1
ListWith60ListItems.default 643 658 0.98:1
TreeWith60ListItems.default 182 185 0.98:1
Tooltip.Fluent 589 600 0.98:1
CardMinimalPerf.default 572 587 0.97:1
FormMinimalPerf.default 432 447 0.97:1
RosterPerf.default 1154 1187 0.97:1
IconMinimalPerf.default 674 695 0.97:1
TextMinimalPerf.default 381 391 0.97:1
ChatDuplicateMessagesPerf.default 368 382 0.96:1
RadioGroupMinimalPerf.default 449 466 0.96:1
AccordionMinimalPerf.default 159 173 0.92:1

@chrisdholt chrisdholt merged commit c4508a1 into microsoft:master Feb 8, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v0.13.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants