Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web components to use latest version of fast-element #14573

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Update web components to use latest version of fast-element #14573

merged 2 commits into from
Aug 18, 2020

Conversation

chrisdholt
Copy link
Member

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

@chrisdholt chrisdholt mentioned this pull request Aug 17, 2020
Closed
12 tasks
@chrisdholt chrisdholt force-pushed the users/chhol/update-web-component-dependencies branch from fe1d4e0 to fc78ded Compare August 17, 2020 23:07
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fe1d4e0:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 876 891 5000
ButtonNext mount 591 589 5000
Checkbox mount 1533 1608 5000
CheckboxBase mount 1268 1268 5000
CheckboxNext mount 1642 1669 5000
ChoiceGroup mount 4865 4984 5000
ComboBox mount 923 934 1000
CommandBar mount 7641 7496 1000
ContextualMenu mount 13549 13222 1000
DefaultButton mount 1083 1110 5000
DetailsRow mount 3479 3463 5000
DetailsRowFast mount 3528 3514 5000
DetailsRowNoStyles mount 3429 3290 5000
Dialog mount 1495 1505 1000
DocumentCardTitle mount 1813 1780 1000
Dropdown mount 2633 2627 5000
FocusZone mount 1784 1833 5000
IconButton mount 1676 1724 5000
Label mount 344 343 5000
Link mount 436 437 5000
LinkNext mount 493 492 5000
MenuButton mount 1428 1423 5000
Nav mount 3274 3167 1000
Panel mount 1467 1460 1000
Persona mount 830 826 1000
Pivot mount 1399 1387 1000
PivotNext mount 1376 1385 1000
PrimaryButton mount 1250 1294 5000
SearchBox mount 1241 1276 5000
SearchBoxNext mount 1303 1327 5000
Slider mount 1498 1519 5000
SliderNext mount 1904 1919 5000
SpinButton mount 4978 4941 5000
SpinButtonNext mount 5036 4992 5000
Spinner mount 430 442 5000
SplitButton mount 3085 3074 5000
Stack mount 513 498 5000
StackWithIntrinsicChildren mount 1938 1887 5000
StackWithTextChildren mount 4915 4895 5000
TagPicker mount 2649 2639 5000
Text mount 448 416 5000
TextField mount 1391 1390 5000
ThemeProvider mount 2809 2844 5000
ThemeProvider virtual-rerender 463 450 5000
Toggle mount 832 817 5000
ToggleNext mount 825 822 5000
button mount 113 123 5000

Perf Analysis (Fluent)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 111 47 2.36:1 analysis
ListNestedPerf.default 571 847 0.67:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.43 0.46 0.93:1 2000 852
🦄 Button.Fluent 0.1 0.19 0.53:1 5000 522
🔧 Checkbox.Fluent 0.63 0.32 1.97:1 1000 634
🎯 Dialog.Fluent 0.15 0.21 0.71:1 5000 746
🔧 Dropdown.Fluent 2.93 0.47 6.23:1 1000 2927
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 681
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 362
🔧 Slider.Fluent 1.61 0.36 4.47:1 1000 1606
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 333
🦄 Tooltip.Fluent 0.1 16.69 0.01:1 5000 509

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonUseCssNestingPerf.default 62 45 1.38:1
ButtonUseCssPerf.default 56 43 1.3:1
AttachmentMinimalPerf.default 162 144 1.13:1
PortalMinimalPerf.default 130 115 1.13:1
ButtonMinimalPerf.default 175 158 1.11:1
ImageMinimalPerf.default 359 330 1.09:1
ProviderMinimalPerf.default 974 897 1.09:1
AnimationMinimalPerf.default 407 378 1.08:1
LayoutMinimalPerf.default 395 366 1.08:1
ListMinimalPerf.default 474 439 1.08:1
TableMinimalPerf.default 403 374 1.08:1
Text.Fluent 333 308 1.08:1
DividerMinimalPerf.default 353 329 1.07:1
SegmentMinimalPerf.default 351 329 1.07:1
BoxMinimalPerf.default 342 324 1.06:1
CardMinimalPerf.default 543 514 1.06:1
AlertMinimalPerf.default 297 282 1.05:1
ChatMinimalPerf.default 584 558 1.05:1
IconMinimalPerf.default 667 636 1.05:1
AttachmentSlotsPerf.default 1114 1074 1.04:1
CarouselMinimalPerf.default 444 427 1.04:1
DropdownManyItemsPerf.default 765 734 1.04:1
HeaderMinimalPerf.default 338 326 1.04:1
PopupMinimalPerf.default 672 646 1.04:1
RadioGroupMinimalPerf.default 413 396 1.04:1
ReactionMinimalPerf.default 381 368 1.04:1
Image.Fluent 362 349 1.04:1
AvatarMinimalPerf.default 464 449 1.03:1
ChatDuplicateMessagesPerf.default 402 389 1.03:1
FlexMinimalPerf.default 279 270 1.03:1
InputMinimalPerf.default 1316 1279 1.03:1
SkeletonMinimalPerf.default 396 386 1.03:1
CustomToolbarPrototype.default 3773 3677 1.03:1
ButtonSlotsPerf.default 584 572 1.02:1
EmbedMinimalPerf.default 1865 1829 1.02:1
GridMinimalPerf.default 315 310 1.02:1
ItemLayoutMinimalPerf.default 1225 1200 1.02:1
LabelMinimalPerf.default 386 378 1.02:1
ProviderMergeThemesPerf.default 1946 1908 1.02:1
StatusMinimalPerf.default 655 645 1.02:1
TextMinimalPerf.default 332 324 1.02:1
TooltipMinimalPerf.default 765 752 1.02:1
Slider.Fluent 1606 1571 1.02:1
Tooltip.Fluent 509 501 1.02:1
ChatWithPopoverPerf.default 460 456 1.01:1
LoaderMinimalPerf.default 745 736 1.01:1
RefMinimalPerf.default 207 205 1.01:1
SliderMinimalPerf.default 1588 1570 1.01:1
SplitButtonMinimalPerf.default 3677 3651 1.01:1
VideoMinimalPerf.default 592 589 1.01:1
Checkbox.Fluent 634 630 1.01:1
Dropdown.Fluent 2927 2909 1.01:1
Icon.Fluent 681 673 1.01:1
FormMinimalPerf.default 385 385 1:1
HeaderSlotsPerf.default 756 754 1:1
MenuMinimalPerf.default 827 826 1:1
MenuButtonMinimalPerf.default 1484 1491 1:1
TableManyItemsPerf.default 2126 2126 1:1
Avatar.Fluent 852 852 1:1
Dialog.Fluent 746 744 1:1
DialogMinimalPerf.default 741 750 0.99:1
DropdownMinimalPerf.default 2919 2937 0.99:1
TextAreaMinimalPerf.default 440 443 0.99:1
ToolbarMinimalPerf.default 916 922 0.99:1
TreeWith60ListItems.default 208 210 0.99:1
Button.Fluent 522 525 0.99:1
CheckboxMinimalPerf.default 2780 2855 0.97:1
TreeMinimalPerf.default 840 862 0.97:1
AccordionMinimalPerf.default 136 144 0.94:1
ListWith60ListItems.default 922 1057 0.87:1
ListCommonPerf.default 644 907 0.71:1

@size-auditor
Copy link

size-auditor bot commented Aug 17, 2020 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: aa8c16b569559b87d90f05d2a5f4cfb165247b2c (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 18, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2f30edf:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@chrisdholt chrisdholt force-pushed the users/chhol/update-web-component-dependencies branch from fc78ded to 2f30edf Compare August 18, 2020 00:35
@chrisdholt chrisdholt merged commit 298f84c into microsoft:master Aug 18, 2020
@chrisdholt chrisdholt deleted the users/chhol/update-web-component-dependencies branch August 18, 2020 01:30
@msft-github-bot
Copy link
Contributor

🎉@fluentui/web-components@v0.1.7 has been released which incorporates this pull request.:tada:

Handy links:

levithomason pushed a commit to levithomason/fluentui that referenced this pull request Aug 24, 2020
@chrisdholt @levithomason
Update web components to use latest version of fast-element (microsof…
439812c 
…t#14573)

* update fast element version to leverage latest changes

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@nicholasrice nicholasrice nicholasrice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrisdholt @msft-github-bot @EisenbergEffect @nicholasrice @khmakoto