Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo] Fix (most) printing issues when trying to print the page #3370

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

PascalVorwerk
Copy link
Contributor

@PascalVorwerk PascalVorwerk commented Feb 15, 2025

Pull Request

📖 Description

Solving several issues like stated in the issue #3345:

  • Pages now are printed on a new page for each H2 (except the first H2) found.
  • The videos page does not have video's in the printed version, but a link to each video.
  • Hiding certain UI elements that are not relevant when printing a single page like the header, nav menu, footer and aside.
  • Hiding interactive elements like buttons.
  • Whenever a FluentTabs element is used, all the content for each tab will be placed below eachother, instead of only 1 tab showing in the printed version.

🎫 Issues

#3345

👩‍💻 Reviewer Notes

If you find any more issues on pages please let me know, it was really hard to go about each page and find elements that are not correctly printed yet, so i might have missed some!

📑 Test Plan

Run the Demo website locally and try to print the pages in multiple browsers. I have tried Chrome and Microsoft Edge.

✅ Checklist

General

  • I have added tests for my changes. (Not applicable i think?)
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes. (Not applicable i think?)
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@vnbaaij vnbaaij linked an issue Feb 15, 2025 that may be closed by this pull request
@vnbaaij vnbaaij added this to the v4.11.5 milestone Feb 15, 2025
@vnbaaij
Copy link
Collaborator

vnbaaij commented Feb 15, 2025

This is great. Thanks!

@vnbaaij vnbaaij merged commit 88c5202 into microsoft:dev Feb 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Page printing in templates
3 participants