Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Components inheriting ListComponentBase missing member descriptions #2735

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

oneolddev
Copy link
Contributor

Pull Request

πŸ“– Description

Fixes issue where member description missing from components inheriting from ListComponentBase<>.

🎫 Issues

image

πŸ‘©β€πŸ’» Reviewer Notes

image

I added a private function that recursively searches for a possible description in one of the base classes.

πŸ“‘ Test Plan

Visually checked.

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@oneolddev
Copy link
Contributor Author

I'm not sure why Build and Test Core Lib / Build and Test Core Lib (pull_request) is failing. It appears it has something to do with

warning : [coverlet] badimageformatexception during metadatareaderprovider.fromportablepdbstream in instrumentationhelper.portablepdbhaslocalsource, unable to check if module has got local source.

Help!

@oneolddev
Copy link
Contributor Author

@vnbaaij, Your re-run worked. πŸ™‚ What changed?

@vnbaaij
Copy link
Collaborator

vnbaaij commented Sep 30, 2024

Nothing! Just gets stuck that way sometimes. Have not had time (interest) to dig into it yet

@vnbaaij vnbaaij merged commit 6ab8a2b into microsoft:dev Sep 30, 2024
4 checks passed
@vnbaaij vnbaaij added this to the V4.10.2 milestone Oct 1, 2024
@oneolddev oneolddev deleted the missing-desc branch October 5, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants