Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Multiplatform Build Typo Issue #4756

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Dec 18, 2024

Description

ADO pipelines print a "true" boolean as "True" so we need to change the case comparison to be case insensitive.

Related issues

AB#135348

Testing

https://microsofthealthoss.visualstudio.com/FhirServer/_build/results?buildId=42992&view=results

CleanShot 2024-12-18 at 11 36 35

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner December 18, 2024 19:30
@mikaelweave mikaelweave added this to the S156 milestone Dec 18, 2024
@mikaelweave mikaelweave added Bug Bug bug bug. Open source This change is only relevant to the OSS code or release. labels Dec 18, 2024
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave mikaelweave merged commit 9b913f9 into main Dec 20, 2024
50 of 56 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/fix-buildx-issue branch December 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants