Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mirrored buildx for PRs Only #4753

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Dec 16, 2024

Description

The mirrored buildx is producing invalid multi-platform images. This isn't causing issues with PRs which build for a single platform. Changing logic to only use mirror for PRs.

Related issues

AB#135348

Testing

Running commands locally.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner December 16, 2024 22:19
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave mikaelweave changed the title test docker install for buildx Use mirrored buildx for PRs Only Dec 17, 2024
@mikaelweave mikaelweave added this to the S156 milestone Dec 17, 2024
@mikaelweave mikaelweave added Bug Bug bug bug. Open source This change is only relevant to the OSS code or release. labels Dec 17, 2024
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@mikaelweave mikaelweave merged commit 4848f21 into main Dec 17, 2024
47 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/fix-buildx-issue branch December 17, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants