Prevent reporting dups on worker restart #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyGaluzo
added
Bug
| @@ -332,6 +334,94 @@ public async Task GivenIncrementalLoad_WhenOutOfOrder_ThenCurrentDatabaseVersion | |||
| Assert.Equal(GetLastUpdated("2001"), result.Resource.Meta.LastUpdated); // version 1 imported | |||
| } | |||
|
|
|||
| [Fact(Skip = "requires new stored procedures")] | |||
There was a problem hiding this comment.
Which new stored procedures? Is there a work item number that can be put here so we know when these can be enabled?
There was a problem hiding this comment.
Not now. It depends on results of future discussion on whether behaviors in the skipped tests are desirable or not.
LTA-Thinking
previously approved these changes
Mar 25, 2024
LTA-Thinking
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra checks to prevent reporting dups. Fixes
https://microsofthealth.visualstudio.com/Health/_workitems/edit/118113