fix: acccordion expand mode changes should update the UI as expected #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
requested review from
EisenbergEffect,
nicholasrice and
janechu
as code owners
chrisdholt
force-pushed
the
users/chhol/ensure-swapping-to-multi-expand-removes-disabled-attr
branch
from
e44fc22 to
369f3d5
Compare
eljefe223
approved these changes
Jan 20, 2023
YonatanKra
reviewed
Jan 27, 2023
packages/web-components/fast-foundation/src/accordion/accordion.pw.spec.ts
Outdated
Show resolved
Hide resolved
chrisdholt
force-pushed
the
users/chhol/ensure-swapping-to-multi-expand-removes-disabled-attr
branch
from
e1c82bd to
f92f293
Compare
chrisdholt
force-pushed
the
users/chhol/ensure-swapping-to-multi-expand-removes-disabled-attr
branch
from
f92f293 to
d2f9618
Compare
chrisdholt
deleted the
users/chhol/ensure-swapping-to-multi-expand-removes-disabled-attr
branch
9 tasks
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
…6611) * fixes an issue where accordion expand-mode changes were not reflected in the component * Change files * update api report * go back to aria-disabled as it removes the item from the tabindex, duh * fixup accordion tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Fixes an issue where swapping expand modes did not trigger the proper updates to the accordion component. This also goes back to setting an item's expand button to aria-disabled attribute vs. disabled.
🎫 Issues
fixes #6586
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps