Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Refactor Project Structure #325

Merged
merged 9 commits into from
Nov 4, 2020
Merged

Refactor Project Structure #325

merged 9 commits into from
Nov 4, 2020

Conversation

evanlouie
Copy link
Contributor

@evanlouie evanlouie commented Nov 4, 2020 •
edited
Loading

  • All packages except the top level cmd/cli/main.go are now internal
    • Note that internal directories has a special meaning in golang.
  • To build, we now run go build -o fab cmd/cli/main.go
  • Refactored Helm functionality out of the helm generator into its own package (/internal/helm)
  • Refactored Git functionality out of core into its own package (/internal/git)

closes #318

@evanlouie evanlouie changed the title Refactor pkgs Refactor Project Structure Nov 4, 2020
andrewDoing
andrewDoing previously requested changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@andrewDoing andrewDoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the contributing docs be updated with the new build command?

internal/git/core.go Show resolved Hide resolved
@evanlouie evanlouie requested a review from andrewDoing November 4, 2020 21:36
@evanlouie evanlouie merged commit 9650c0e into develop Nov 4, 2020
@evanlouie evanlouie deleted the refactor-pkgs branch November 4, 2020 22:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewDoing andrewDoing andrewDoing approved these changes

@timfpark timfpark Awaiting requested review from timfpark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code base reorganization into modules
2 participants
@evanlouie @andrewDoing