This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fix method: git for non type: component
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlouie
commented
Oct 29, 2019
| // Install for StaticGenerator gives the ability to point to a single yaml | ||
| // manifest over `method: http`; This is a noop for any all other methods. | ||
| func (sg *StaticGenerator) Install(c *core.Component) (err error) { | ||
| if strings.EqualFold(c.Method, "http") { |
There was a problem hiding this comment.
@edaena note: the logic for your previous remote yaml components has been moved here
A regression arouse where components of `type: helm` and `method: git` were not being correctly cloned from git during `fab install`. This fixes this issue and refactors the `InstallComponent` code to be less strict on when to meet certain cases. This PR also refactors some code for installing components which point to YAML files over `method: http`. Previously the logic for the installation of these components were stored in `component.go`, this lead to confusion for the logic in `InstallComponent`, causing the regression this PR fixes. The logic for installing static remote components has been refactored into the `static.go` generator.
evanlouie
force-pushed
the
fix-git-helm
branch
from
f46485f to
c1f57eb
Compare
yradsmikham
approved these changes
Oct 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression arouse where components of
type: helmandmethod: gitwere notbeing correctly cloned from git during
fab install. This fixes this issue andrefactors the
InstallComponentcode to be less strict on when to meet certaincases.
This PR also refactors some code for installing components which point to YAML
files over
method: http. Previously the logic for the installation of thesecomponents were stored in
component.go, this lead to confusion for the logicin
InstallComponent, causing the regression this PR fixes. The logic forinstalling static remote components has been refactored into the
static.gogenerator.