Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static CRT for now #38

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Use static CRT for now #38

merged 1 commit into from
Jun 28, 2024

Conversation

csujedihy
Copy link
Contributor

Currently, the libs used in XDP functional tests are built with static CRT runtime. Cxplat has been using dynamic CRT, which causes a conflict (which I previously thought it was the other way around- cxplat using static CRT while xdp test stuff using dynamic CRT).

This allows me to get rid of /nodefaultlib hacks in XDP.

     3>LIBCMTD.lib(initializers.obj) : warning LNK4098: defaultlib 'msvcrtd.lib' conflicts with use of other libs; use /NODEFAULTLIB:library [D:\xdp-for-windows\test\functional\taef\xdpfunctionaltests.vcxproj]
     3>LINK : error LNK1218: warning treated as error; no output file generated [D:\xdp-for-windows\test\functional\taef\xdpfunctionaltests.vcxproj]
     3>Done Building Project "D:\xdp-for-windows\test\functional\taef\xdpfunctionaltests.vcxproj" (default targets) -- FAILED

@csujedihy csujedihy merged commit e48cee4 into main Jun 28, 2024
75 checks passed
@csujedihy csujedihy deleted the huanyi/use-static-crt branch June 28, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant