IReference operators need to go into the level-1 header #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way they are defined whenever the interface is defined.
|
@kennykerr Note that |
|
@oldnewthing That's a remnant of the xlang side project that aimed to support C++/WinRT on non-Windows metadata. That's been canned so we can remove those conditionals. |
oldnewthing
added a commit
that referenced
this pull request
Jun 24, 2021
Implementation relies on methods in the top-level header, so defer implementation to there. This reverts the change to base_reference_produce.h from #906 and reduces base_reference_produce_1.h to merely forward references. This is enough to get structures to compile, although you cannot meaningfully use any IReferences in them until you include Windows.Foundation.h (which is consistent with existing rules for namespace headers).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way they are defined whenever the interface is defined.
This brings
IReference<T>in line with all other types with customoperator==, which had already defined those operators at the point the type is defined.Note that
operator co_awaitis still defined in the top header even though the type being co-awaited is defined in the level-1 or level-2 header. This isn't a problem in practice because if you try toco_awaitaDispatcherQueue(say), without having included the top-level header, you will be told, "I don't know how to co_await a DispatcherQueue" because the DispatcherQueue doesn't implement await_ready.Fixes #801