Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/oakeredolu/pipsharedcache #695

Closed
wants to merge 4 commits into from
Closed

Conversation

Omotola
Copy link
Contributor

@Omotola Omotola commented Aug 3, 2023

Shared cache for the old and new pip detectors to help with performance

@Omotola Omotola requested a review from a team as a code owner August 3, 2023 00:05
@Omotola Omotola requested a review from amitla1 August 3, 2023 00:05
return Task.FromResult<HttpResponseMessage>(null);
}

return this.GetAndCachePyPiResponseAsync(requestUri);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this bypassing the cache?

Copy link
Contributor Author

@Omotola Omotola Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be adding to cache here instead. fixed it. There's a check to get from cache at the top of this conditional before it gets to this point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I think I misunderstood your question. do you mean is the shared cache bypassing this internal cache? yes it is, i'm checking the shared cache first and if it returns nothing, then it enters this retry block and tries to get from the internal cache and if that returns nothing, it sends a request to the pypi api.

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@melotic melotic closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants