Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where pipreport used index-urls from requirements.txt #1227

Merged
merged 6 commits into from
Aug 19, 2024

Conversation

pauld-msft
Copy link
Member

Customers' pipelines are being broken because they are using file level requirements.txt index urls. This adds an option to disable those

@pauld-msft pauld-msft requested a review from a team as a code owner August 16, 2024 16:22
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.5%. Comparing base (f27fe8e) to head (c61943c).
Report is 1 commits behind head on main.

Files Patch % Lines
...ponentDetection.Detectors/pip/PipCommandService.cs 88.7% 5 Missing and 2 partials ⚠️
...ft.ComponentDetection.Common/FileUtilityService.cs 95.2% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1227   +/-   ##
=====================================
  Coverage   76.4%   76.5%           
=====================================
  Files        258     258           
  Lines      11671   11712   +41     
  Branches    1180    1187    +7     
=====================================
+ Hits        8925    8962   +37     
- Misses      2406    2409    +3     
- Partials     340     341    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 16, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@grvillic
Copy link
Contributor

Since this change may pick up different dependencies we might want to bump the Pip report detector's version number.

@pauld-msft pauld-msft enabled auto-merge (squash) August 19, 2024 12:37
@pauld-msft pauld-msft merged commit edf0c8d into main Aug 19, 2024
23 of 26 checks passed
@pauld-msft pauld-msft deleted the pauldorsch/pipreport-fixes branch August 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants