-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where pipreport used index-urls from requirements.txt #1227
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1227 +/- ##
=====================================
Coverage 76.4% 76.5%
=====================================
Files 258 258
Lines 11671 11712 +41
Branches 1180 1187 +7
=====================================
+ Hits 8925 8962 +37
- Misses 2406 2409 +3
- Partials 340 341 +1 ☔ View full report in Codecov by Sentry. |
src/Microsoft.ComponentDetection.Detectors/pip/PipCommandService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/pip/PipCommandService.cs
Outdated
Show resolved
Hide resolved
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
Since this change may pick up different dependencies we might want to bump the Pip report detector's version number. |
Customers' pipelines are being broken because they are using file level
requirements.txt
index urls. This adds an option to disable those