Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FileVersionInfo for PEImage #412

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Implement FileVersionInfo for PEImage #412

merged 2 commits into from
Dec 13, 2019

Conversation

arvindshmicrosoft
Copy link
Member

Addresses #398 in 1.1

leculver
leculver requested changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@leculver leculver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately one of the hard requirements of ClrMD 1.1 is that it doesn't carry any dependencies. In order for me to merge this you'll have to strip out the nuget packages that were added and reimplement using byte[] or byte* instead of Span.

src/Microsoft.Diagnostics.Runtime/Microsoft.Diagnostics.Runtime.csproj Outdated Show resolved Hide resolved
src/Microsoft.Diagnostics.Runtime/src/Utilities/PEImage/FileVersionInfo.cs Outdated Show resolved Hide resolved
@leculver
Copy link
Contributor

This version looks good! I'll ship a release sometime next week unless you need it today.

@leculver leculver merged commit 92a54f3 into microsoft:release/1.1 Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leculver leculver leculver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvindshmicrosoft @leculver