Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Unable to load user info" on refresh when deployed to Azure #485

Closed
dehoward opened this issue Oct 9, 2023 · 2 comments
Closed

"Unable to load user info" on refresh when deployed to Azure #485

dehoward opened this issue Oct 9, 2023 · 2 comments
Assignees
@dehoward
Labels
bug Something isn't working regression Issues related to regressions in functionality sk team issue

Comments

@dehoward
Copy link
Contributor

dehoward commented Oct 9, 2023

Describe the bug
User info object is not correctly set on reload.

To Reproduce
Steps to reproduce the behavior:

  1. Deploy app to Azure
  2. Login using AAD
  3. Refresh

Expected behavior
User is still logged in

Screenshots
image

Platform

  • OS: [e.g. Windows, Mac]
  • IDE: [e.g. Visual Studio, VS Code]
  • Language: [e.g. C#, Python]
  • Source: [e.g. NuGet package version 0.1.0, pip package version 0.1.0, main branch of repository]

Additional context
Add any other context about the problem here.
@dehoward dehoward added bug Something isn't working regression Issues related to regressions in functionality labels Oct 9, 2023
@dehoward dehoward self-assigned this Oct 9, 2023
@dehoward dehoward moved this from In review to Bugs in Apps & Services Semantic Kernel Oct 9, 2023
@TaoChenOSU
Copy link
Contributor

@glahaye Could you take a look at this? I think it's related to the removal of the static webapp.

@dehoward
Copy link
Contributor Author

@TaoChenOSU I'm planning to address this bug this week - I believe its related to #427.

@dehoward dehoward mentioned this issue Oct 12, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 12, 2023
@dehoward
Fix error loading user on refresh (#493)
63c79e8 
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
addresses #485

### Description
casting leads to errors 😢

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
@dehoward dehoward mentioned this issue Oct 12, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2023
@dehoward
Remove /healthz call + use token when calling /maintenanceStatus (#495)
d8ac3b9 
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
the call to `/healthz` isn't needed since we can determine if the
backend is down when calling `/maintenanceStatus`.
the call to `/maintenanceStatus` throws a 401 when AAD is used since the
token is not passed. noticed this when fixing #485.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Ryangr0 pushed a commit to webgrip/chat-copilot that referenced this issue Oct 26, 2023
@dehoward @Ryangr0
Remove /healthz call + use token when calling /maintenanceStatus (mic…
6776832 
…rosoft#495)

### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
the call to `/healthz` isn't needed since we can determine if the
backend is down when calling `/maintenanceStatus`.
the call to `/maintenanceStatus` throws a 401 when AAD is used since the
token is not passed. noticed this when fixing microsoft#485.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this issue Oct 7, 2024
@dehoward
Fix error loading user on refresh (microsoft#493)
7e405d0 
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
addresses microsoft#485

### Description
casting leads to errors 😢

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this issue Oct 7, 2024
@dehoward
Remove /healthz call + use token when calling /maintenanceStatus (mic…
e17154d 
…rosoft#495)

### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
the call to `/healthz` isn't needed since we can determine if the
backend is down when calling `/maintenanceStatus`.
the call to `/maintenanceStatus` throws a 401 when AAD is used since the
token is not passed. noticed this when fixing microsoft#485.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
kb0039 pushed a commit to aaronba/chat-copilot that referenced this issue Jan 8, 2025
@dehoward
Fix error loading user on refresh (microsoft#493)
7ea84d4 
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
addresses microsoft#485

### Description
casting leads to errors 😢

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
kb0039 pushed a commit to aaronba/chat-copilot that referenced this issue Jan 8, 2025
@dehoward
Remove /healthz call + use token when calling /maintenanceStatus (mic…
1a596bb 
…rosoft#495)

### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
the call to `/healthz` isn't needed since we can determine if the
backend is down when calling `/maintenanceStatus`.
the call to `/maintenanceStatus` throws a 401 when AAD is used since the
token is not passed. noticed this when fixing microsoft#485.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehoward dehoward

Labels
bug Something isn't working regression Issues related to regressions in functionality sk team issue
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TaoChenOSU @dehoward