Some below-base anchor points are too high #499
Comments
|
I’ll take a look, but I’m not sure most of those even have base anchors because AFAIK no script uses them thus. Why are you putting diacritics on them? |
|
All of them have base anchors. I found them by checking all the base glyphs using that anchor. If they had not used an anchor, I would not have reported this, but Cascadia is currently going out of its way to position marks incorrectly. |
|
Ah. This is probably a case of the propagateAnchors script being overzealous. Thanks. TBH, I don’t expect folks to be putting combining macron below on these glyphs, so I’m not super concerned (if they didn’t have anchors the positioning would still be wrong) but I’ll see what can be done to correct it. |
7 tasks
DHowett
pushed a commit
that referenced
this issue
Jun 18, 2021
Major update! This update includes the brand new Arabic and Hebrew language coverage, along with a variety of bug fixes to the upright and italic fonts. There has also been a major overhaul of the Cascadia Code Italic lowercase to make the forms align better with our vision for the font. Enjoy :). Supersedes #491 Cascadia Code * [x] Closes #84 - Arabic language support added! * [x] Closes #465 - Hebrew language support added! * [x] Closes #499 - Adjusted base mark positions / set others to be ignored in propagateAnchors Cascadia Code Italic * [x] Closes #470 - Adjusted slant on cursive forms to feel a bit better * [x] Closes #468 - Moved cursive forms to `ss01` / `salt` feature * [x] Closes #507 - Changed bar / broken bar to be upright for better clarity. All ligature forms adjusted. Both * [x] Closes #494 - Adjusted `ƒ` in both upright and italic - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the Arabic features PDF] for the exciting new Arabic ligature functionality used in Cascadia Code that gives the font greatly improved readability and feel more more akin to a text typeface. Don't want all that? Don't worry, Cascadia Mono will house a normal version of Arabic. - Hebrew support added (design by Liron Lavi Turkenich) - Fixing a bug in the ccmp feature file and added ccmp to the feature set in the build script. - Deleting the (unused) liga feature file - Vika has reviewed and improved some forms in Cascadia Code upright. - /f, /l, /s, /r (and related forms) have been updated to follow more 'generic' forms. Previous versions have been moved to ss01 / salt OT features. - Changed design of `ƒ` in upright to align better with the standard `f`. In the italic, the `ƒ` has been changed to follow the cursive version. When `ss01` is applied, the design of the `f` and `ƒ` are swapped, and if the `locl` EWE language setting is applied, the 'f' swaps for a straight descender version (with cursive `ƒ`). Complicated, but achieves supporting everything. - Entry and exit strokes across the italic lowercase have been rounded to better achieve the fun / playful design language that we intended for the italic. Other skeletons have been modified as necessary. Cyrillic has also been updated for better consistency with the new design. - Greek lowercase has been updated per feedback from Gerry Leonidas to be more cohesive (No longer a mix between a Monday and Friday font. All Friday, all the time) ## Validation Steps Performed All updated reviewed, hinted, and reviewed again :) [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell
added a commit
to aaronbell/cascadia-code
that referenced
this issue
Jun 21, 2021
commit e9aa335 Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com> Date: Sat Jun 19 00:42:28 2021 +0600 Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385) Co-authored-by: Aaron <aaronbell@users.noreply.github.com> commit fb0bce6 Author: Aaron <aaronbell@users.noreply.github.com> Date: Fri Jun 18 10:37:03 2021 -0700 Add Hebrew and Arabic; rework Italic (microsoft#511) Major update! This update includes the brand new Arabic and Hebrew language coverage, along with a variety of bug fixes to the upright and italic fonts. There has also been a major overhaul of the Cascadia Code Italic lowercase to make the forms align better with our vision for the font. Enjoy :). Supersedes microsoft#491 Cascadia Code * [x] Closes microsoft#84 - Arabic language support added! * [x] Closes microsoft#465 - Hebrew language support added! * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be ignored in propagateAnchors Cascadia Code Italic * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better clarity. All ligature forms adjusted. Both * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the Arabic features PDF] for the exciting new Arabic ligature functionality used in Cascadia Code that gives the font greatly improved readability and feel more more akin to a text typeface. Don't want all that? Don't worry, Cascadia Mono will house a normal version of Arabic. - Hebrew support added (design by Liron Lavi Turkenich) - Fixing a bug in the ccmp feature file and added ccmp to the feature set in the build script. - Deleting the (unused) liga feature file - Vika has reviewed and improved some forms in Cascadia Code upright. - /f, /l, /s, /r (and related forms) have been updated to follow more 'generic' forms. Previous versions have been moved to ss01 / salt OT features. - Changed design of `ƒ` in upright to align better with the standard `f`. In the italic, the `ƒ` has been changed to follow the cursive version. When `ss01` is applied, the design of the `f` and `ƒ` are swapped, and if the `locl` EWE language setting is applied, the 'f' swaps for a straight descender version (with cursive `ƒ`). Complicated, but achieves supporting everything. - Entry and exit strokes across the italic lowercase have been rounded to better achieve the fun / playful design language that we intended for the italic. Other skeletons have been modified as necessary. Cyrillic has also been updated for better consistency with the new design. - Greek lowercase has been updated per feedback from Gerry Leonidas to be more cohesive (No longer a mix between a Monday and Friday font. All Friday, all the time) ## Validation Steps Performed All updated reviewed, hinted, and reviewed again :) [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell
added a commit
to aaronbell/cascadia-code
that referenced
this issue
Jun 23, 2021
commit e9aa335 Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com> Date: Sat Jun 19 00:42:28 2021 +0600 Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385) Co-authored-by: Aaron <aaronbell@users.noreply.github.com> commit fb0bce6 Author: Aaron <aaronbell@users.noreply.github.com> Date: Fri Jun 18 10:37:03 2021 -0700 Add Hebrew and Arabic; rework Italic (microsoft#511) Major update! This update includes the brand new Arabic and Hebrew language coverage, along with a variety of bug fixes to the upright and italic fonts. There has also been a major overhaul of the Cascadia Code Italic lowercase to make the forms align better with our vision for the font. Enjoy :). Supersedes microsoft#491 Cascadia Code * [x] Closes microsoft#84 - Arabic language support added! * [x] Closes microsoft#465 - Hebrew language support added! * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be ignored in propagateAnchors Cascadia Code Italic * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better clarity. All ligature forms adjusted. Both * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the Arabic features PDF] for the exciting new Arabic ligature functionality used in Cascadia Code that gives the font greatly improved readability and feel more more akin to a text typeface. Don't want all that? Don't worry, Cascadia Mono will house a normal version of Arabic. - Hebrew support added (design by Liron Lavi Turkenich) - Fixing a bug in the ccmp feature file and added ccmp to the feature set in the build script. - Deleting the (unused) liga feature file - Vika has reviewed and improved some forms in Cascadia Code upright. - /f, /l, /s, /r (and related forms) have been updated to follow more 'generic' forms. Previous versions have been moved to ss01 / salt OT features. - Changed design of `ƒ` in upright to align better with the standard `f`. In the italic, the `ƒ` has been changed to follow the cursive version. When `ss01` is applied, the design of the `f` and `ƒ` are swapped, and if the `locl` EWE language setting is applied, the 'f' swaps for a straight descender version (with cursive `ƒ`). Complicated, but achieves supporting everything. - Entry and exit strokes across the italic lowercase have been rounded to better achieve the fun / playful design language that we intended for the italic. Other skeletons have been modified as necessary. Cyrillic has also been updated for better consistency with the new design. - Greek lowercase has been updated per feedback from Gerry Leonidas to be more cohesive (No longer a mix between a Monday and Friday font. All Friday, all the time) ## Validation Steps Performed All updated reviewed, hinted, and reviewed again :) [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell
added a commit
to aaronbell/cascadia-code
that referenced
this issue
Jun 23, 2021
Major update! This update includes the brand new Arabic and Hebrew language coverage, along with a variety of bug fixes to the upright and italic fonts. There has also been a major overhaul of the Cascadia Code Italic lowercase to make the forms align better with our vision for the font. Enjoy :). Supersedes microsoft#491 Cascadia Code * [x] Closes microsoft#84 - Arabic language support added! * [x] Closes microsoft#465 - Hebrew language support added! * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be ignored in propagateAnchors Cascadia Code Italic * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better clarity. All ligature forms adjusted. Both * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the Arabic features PDF] for the exciting new Arabic ligature functionality used in Cascadia Code that gives the font greatly improved readability and feel more more akin to a text typeface. Don't want all that? Don't worry, Cascadia Mono will house a normal version of Arabic. - Hebrew support added (design by Liron Lavi Turkenich) - Fixing a bug in the ccmp feature file and added ccmp to the feature set in the build script. - Deleting the (unused) liga feature file - Vika has reviewed and improved some forms in Cascadia Code upright. - /f, /l, /s, /r (and related forms) have been updated to follow more 'generic' forms. Previous versions have been moved to ss01 / salt OT features. - Changed design of `ƒ` in upright to align better with the standard `f`. In the italic, the `ƒ` has been changed to follow the cursive version. When `ss01` is applied, the design of the `f` and `ƒ` are swapped, and if the `locl` EWE language setting is applied, the 'f' swaps for a straight descender version (with cursive `ƒ`). Complicated, but achieves supporting everything. - Entry and exit strokes across the italic lowercase have been rounded to better achieve the fun / playful design language that we intended for the italic. Other skeletons have been modified as necessary. Cyrillic has also been updated for better consistency with the new design. - Greek lowercase has been updated per feedback from Gerry Leonidas to be more cohesive (No longer a mix between a Monday and Friday font. All Friday, all the time) All updated reviewed, hinted, and reviewed again :) [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cascadia family version
2105.24
Cascadia family variant(s)
Cascadia Code (the version with ligatures), Cascadia Mono (the version without ligatures)
Font file format(s)
.ttf (variable), .ttf (static), .otf (static)
Platform
macOS 10.14.6
Other Software
No response
What happened?
Some glyphs with descenders (including ones precomposed with below-base marks) have anchor points for below-base marks too high, such that the mark overlaps the descender.
Here is <U+0024, U+0051, U+0070, U+0071, U+0079, U+00A2, U+00FD, U+00FE, U+00FF, U+012F, U+0133, U+0173, U+0177, U+0233, U+0272, U+03B2, U+03BE, U+03C1, U+03CF, U+040F, U+0414, U+0426, U+0428, U+0434, U+0443, U+0446, U+0448, U+045E, U+045F, U+0496, U+0497, U+049A, U+049B, U+04A2, U+04A3, U+04AF, U+04B1, U+04B2, U+04B3, U+04B6, U+04B7, U+04EF, U+0E3F, U+1E8F, U+1E99, U+1EF3, U+1EF7, U+1EF9, U+20A1, U+20AB, U+20B2, U+20B5> with U+0331 COMBINING MACRON BELOW after each character. I may have missed some.
The text was updated successfully, but these errors were encountered: