fix lu validation bugs for empty comments and single curly bracket #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
approved these changes
May 7, 2020
|
LGTM, cc @munozemilio @vishwacsena |
feich-ms
changed the title
feich-ms
changed the title
Closed
7 tasks
munozemilio
added a commit
that referenced
this pull request
May 7, 2020
) (#764) * fix lu parser validation issue for empty comments * fix lu parser validation to allow single cruly bracket in utterance Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix minor lu validation issues reported by composer microsoft/BotFramework-Composer#2910 and microsoft/BotFramework-Composer#2940. The fix for 2910 is simple(first commit), just loose the rule to allow comment be empty. The fix for 2940 is also simple(second commit), just allow single curly brackets in utternace. rush test of lu and qna all passed. 2910 is marked R9-RC in composer side, so I think this PR should go into BF-CLI next RC.