Fix compute_hash #450
Merged
Fix compute_hash #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelsrz
approved these changes
Nov 27, 2019
| @@ -24,8 +25,7 @@ def is_changed(self) -> bool: | |||
| return self.hash != self.compute_hash(self.state) | |||
|
|
|||
| def compute_hash(self, obj: object) -> str: | |||
| # TODO: Should this be compatible with C# JsonConvert.SerializeObject ? | |||
| return str(obj) | |||
| return str(Pickler().flatten(obj)) | |||
There was a problem hiding this comment.
Great catch! This is so important that I'm surprised that didn't blow up earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
compute_hashas:...the hashes always return as something like "DialogStack at memoryAddressXYZ". If the DialogStack changes (dialogs added/removed), the memory address doesn't change, so the hash appears to be the same and changes are not written.
With:
...the whole DialogStack would get serialized and changes are correctly detected.
This wasn't detected because
MemoryStoragemanipulates the objects in memory, anyway and doesn't actually need to callMemoryStorage.write(). With persistent storage, write wasn't being called enough and things like ConversationState weren't actually updating, preventing users from progressing through WaterfallDialogs.