Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django: Application Insights accepts TelemetryProcessor or TelemetryClient #336

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

congysu
Copy link
Member

@congysu congysu commented Oct 7, 2019

  • fork django middleware from application insights repo.
  • django middleware now accepts a TelemetryClient that is aware of
    telemetry processor.
  • enable test verifications for the middleware in django tests.

More descriptions are in #150 .

…lient

* fork django middleware from application insights repo.
* django middleware now accepts a TelemetryClient that is aware of
telemetry processor
* enable test verifications for the middleware in django tests.
* format with black.
Copy link
Contributor

@tsuwandy tsuwandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks Congyong!

@daveta
Copy link
Contributor

daveta commented Oct 7, 2019

Wow, nice cleanup and refactor, much clearer! Thank you!

Copy link
Member

@axelsrz axelsrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants