Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming samples and porting to Flask #282

Merged
merged 4 commits into from
Aug 7, 2019
Merged

Conversation

axelsrz
Copy link
Member

@axelsrz axelsrz commented Aug 7, 2019

Ported main samples from aiohttp to Flask. Rename and rearrange of samples to match BotBuilder-Samples.

fixes #212

@axelsrz axelsrz requested review from daveta and stevengum August 7, 2019 18:18
@daveta
Copy link
Contributor

daveta commented Aug 7, 2019

pyyaml>=5.1

Curious if this is required?


Refers to: samples/06.using-cards/requirements.txt:4 in 557f75c. [](commit_id = 557f75c, deletion_comment = False)

@daveta
Copy link
Contributor

daveta commented Aug 7, 2019

  "url": "https://docs.microsoft.com/en-us/azure/bot-service/?view=azure-bot-service-4.0"

Super low pri: FYI: You can remove the "en-us" and I believe it will redirect appropriately..


Refers to: samples/13.core-bot/cards/welcomeCard.json:33 in 557f75c. [](commit_id = 557f75c, deletion_comment = False)

@daveta
Copy link
Contributor

daveta commented Aug 7, 2019

LUIS_API_KEY = ""

Should this have the env check stuff?
ie, os.environ.get("LuisAPIKey", "")


Refers to: samples/21.corebot-app-insights/config.py:15 in 557f75c. [](commit_id = 557f75c, deletion_comment = False)

@daveta
Copy link
Contributor

daveta commented Aug 7, 2019

requests>=2.18.1

We might want to adopt a practice of putting a NOTICE.md (like here ).
Specifically, because requests has a dependency on a LGPL license.


Refers to: samples/python_flask/21.corebot-app-insights/requirements.txt:3 in 557f75c. [](commit_id = 557f75c, deletion_comment = False)

@daveta
Copy link
Contributor

daveta commented Aug 7, 2019

-c "from model_corebot101.language_helper import LanguageHelper; lh = LanguageHelper(). lh.initialize_models(bert_model_dir='/model_runtime_api/model/bert', bidaf_model_dir='/model_runtime_api/model/bidaf')"

Doh! Not needed.


Refers to: samples/experimental/101.corebot-bert-bidaf/Dockerfile_model_runtime:27 in 557f75c. [](commit_id = 557f75c, deletion_comment = False)

@axelsrz
Copy link
Member Author

axelsrz commented Aug 7, 2019

fixed comments @daveta

Copy link
Contributor

@daveta daveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome man! Thanks for doing this!

@axelsrz axelsrz merged commit f415ddd into master Aug 7, 2019
@axelsrz axelsrz deleted the axsuarez/samples-to-flask branch August 12, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move samples over to using flask instead of aiohttp
2 participants