OAuthScope parity with JS and DotNet #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
pushed a commit
to microsoft/teams-ai
that referenced
this pull request
Apr 8, 2024
## Linked issues closes: #1331, #1182 ## Details - With reference to JS, added logic to support `TeamsAttachmentDownloader` (incl updates to `Application` , `InputFile` classes) - Added corresponding tests ## Notes - Contents of a file is represented as **bytes** - Our `configuration` object is of type "**Any**" on the BF side (limitation) - Removed `state` property from `InputFileDownloader` (only `context` is needed) - Removed conversion to lowercase for `toChannelFromBotLoginUrl` constant - this ensures the check for US Government Azure can resolve as True - removed unused `AuthenticResult` interface - Associated [BF PR](microsoft/botbuilder-python#2093) that updates the scopes - #1404 may be a bug in Python as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor