Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for DateTimePrompt and NumberPrompt #177

Merged
merged 3 commits into from
Jul 8, 2019

Conversation

ceciliaavila
Copy link
Collaborator

Proposed Changes

  • Add a new test for DateTimePrompt using Recognizers-Text.DateTime.
    image
  • Add a new test for NumberPrompt using Recognizers-Text.Number.
    image
  • Minor fixes on NumberPrompt class to use recognize_number method (replaced ChoiceRecognizer with NumberRecognizer for parity with DotNet implementation).

We ran all tests locally, also, we configured an Azure Pipeline to automatically run the tests.
image
Note: It's necessary to update the Recognizers-Text-Number package with the fix made in PR# 1554 of Recognizers-Text

Steps to configure a Pipeline for CI:

  1. Add a Use Python task. Configure it to use the latest version of python.
    image
  2. Add a Command Line task to run all the test in the botbuilder-libraries.
    image
    The script used is:
pip install -e ./libraries/botbuilder-schema
pip install -e ./libraries/botframework-connector
pip install -e ./libraries/botbuilder-core 
pip install -e ./libraries/botbuilder-azure
pip install -r ./libraries/botframework-connector/tests/requirements.txt
pip install -e ./libraries/botbuilder-ai
pip install -e ./libraries/botbuilder-dialogs
pip install -e ./libraries/botbuilder-applicationinsights

cd libraries
	
pytest --tb=line

In this image we can see the tests ran successfully:
image

@ceciliaavila ceciliaavila force-pushed the add-date-time-prompt-test branch from 70fdc22 to 06afcc7 Compare May 15, 2019 12:24
@stevengum stevengum requested review from daveta and axelsrz June 5, 2019 20:25
@ceciliaavila ceciliaavila force-pushed the add-date-time-prompt-test branch from 7c7aa6a to 158fc01 Compare July 5, 2019 13:58
@axelsrz axelsrz merged commit 2f3dd0c into microsoft:master Jul 8, 2019
@ceciliaavila ceciliaavila deleted the add-date-time-prompt-test branch July 10, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants