Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Update tools/nyc dependency #4475

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

sw-joelmut
Copy link
Collaborator

#minor

Description

This PR updates the nyc dependency in the tools project from v11.9.0 to v15.1.0 to address security issues with nested dependencies (node_modules).

Specific Changes

  • Updates nyc from v11.9.0 to v15.1.0.
  • Updates tools/unit-coverage script to run the test coverage properly.

Testing

The following images show the difference between the nyc versions, and the unit test coverage working as expected.
image
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 5, 2023 20:06
@coveralls
Copy link

coveralls commented May 5, 2023

Pull Request Test Coverage Report for Build 4897135124

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.859%

Totals Coverage Status
Change from base Build 4894039401: 0.4%
Covered Lines: 20094
Relevant Lines: 22450

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit b110344 into main May 8, 2023
@tracyboehrer tracyboehrer deleted the southworks/update/tools-nyc branch May 8, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants