Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4414] JS Linux Functional Test pipeline failing #4419

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4414

Description

This PR fixes the errors in the JS Linux Functional Test pipeline. It also applies some prettier fixes to the DirectLine tests.

The error TypeError: Cannot read property 'text' of undefined was fixed by upgrading the botSku from F0 to S1, as the bot was throwing an error related to the max transactions being exceeded.
We also had an authorization issue that was solved by upgrading the bot's Node version from 10 to 16.

Specific Changes

  • Updated the functionaltestbot/template/linux/template.json to upgrade the Node version to 16 and the botSku default value to S1.
  • Updated prettier issues in testing/functional/tests/directLine.test.js.

Testing

This image shows the testing pipeline successfully executed after the changes:
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner January 26, 2023 12:00
@coveralls
Copy link

coveralls commented Jan 26, 2023

Pull Request Test Coverage Report for Build 4014919253

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.653%

Totals Coverage Status
Change from base Build 4008840755: -0.003%
Covered Lines: 20002
Relevant Lines: 22391

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 79b1153 into main Jan 31, 2023
@tracyboehrer tracyboehrer deleted the southworks/fix/failing-linux-test branch January 31, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS Linux Functional Test pipeline failing
3 participants