Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#4349] Add new method to expose same functionality as BotFrameworkAdapter.processActivityDirect #4380

Conversation

erquirogasw
Copy link
Contributor

Fixes #4349

Description

This PR exposes the same functionality as the processActivityDirect method of the deprecated BotFrameworkAdapter class. For that, adds a new method that doesn't use HTTP req and res parameters.

Specific Changes

  • New processActivityDirect method that exposes the same functionality that the ones in BotFrameworkAdapter.

Testing

  • All unit tests passed
  • Added unit test for the new method
    image

@coveralls
Copy link

coveralls commented Dec 2, 2022

Pull Request Test Coverage Report for Build 4929341803

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.867%

Totals Coverage Status
Change from base Build 4916290236: 0.4%
Covered Lines: 20104
Relevant Lines: 22459

💛 - Coveralls

…nality-to-CloudAdapter

# Conflicts:
#	libraries/botbuilder/tests/cloudAdapter.test.js
@tracyboehrer tracyboehrer requested a review from ceciliaavila June 9, 2023 13:55
@tracyboehrer tracyboehrer merged commit 5e5d819 into main Oct 17, 2023
@tracyboehrer tracyboehrer deleted the southworks/add/processActivityDirect-functionality-to-CloudAdapter branch October 17, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudAdapter is missing processActivityDirect from BotframeworkAdapter
4 participants