fix: [#4325] Skip Storage properties from BotState class #4326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4325
Description
This PR fixes an issue where the Host calls a Skill using the
BeginSkill
action, and right after ending the conversation with the skill aTextInput
is prompt.Moreover, after the input was prompted and provided the text response, the Host fails, because it tries to call the Skill again.
Furthermore, the Host was trying to call the Skill because the
ConversationState
was being updated with old information due to theBeginSkill
class was saving into the Storage theConversationIdFactory
andConversationState
instances (that also have aStorage
).By skipping the two properties, like DotNet does, solved the issue.
Specific Changes
BotState
class, iterating the state object properties to find and skip the desired properties from outside theBotState
scope, to then compare them in the hash functionality.BeginSkill.beginDialog
method.BotState
andBeginSkill
changes.Testing
The following image shows the comparison between the DotNet's Storage saved information and the one used in JavaScript.