Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chromedriver version updater #4269

Merged
merged 12 commits into from
Jun 25, 2022
Merged

fix: chromedriver version updater #4269

merged 12 commits into from
Jun 25, 2022

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Jun 24, 2022

Fixes #minor

Description

JS-Functional-Tests-BrowserBot-yaml started failing when a new chromedriver version was released, because the driver version is now ahead of the Chrome browser version.

My tests indicate auto updating to the second latest driver version will keep driver and browser versions in better sync.

Specific Changes

Tweak "Upgrade chromedriver reference" step to use the 2nd latest version.

@BruceHaley BruceHaley changed the title Tweak chromedriver version setting fix: chromedriver version updater Jun 24, 2022
@coveralls
Copy link

coveralls commented Jun 24, 2022

Pull Request Test Coverage Report for Build 2558588976

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.479%

Totals Coverage Status
Change from base Build 2516179061: 0.0%
Covered Lines: 19904
Relevant Lines: 22312

💛 - Coveralls

@BruceHaley BruceHaley requested a review from gabog June 24, 2022 23:08
@BruceHaley BruceHaley marked this pull request as ready for review June 24, 2022 23:09
@BruceHaley BruceHaley requested a review from a team as a code owner June 24, 2022 23:09
@gabog gabog merged commit c9b8818 into main Jun 25, 2022
@gabog gabog deleted the bruce/browsertestfix6-23 branch June 25, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants