Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [#3518] Enable 'no-public' accessibility rule in the .eslintrc file #4227

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #3518
#minor

Note: This PR is the last one of the series, that enables the rule to not use public access modifiers, therefore the lint CI pipelines will fail until previous PRs are merged.

Description

This PR removes the current @typescript-eslint/explicit-member-accessibility override and adds a new one to the rules' config, throwing an error when declaring a public access modifier (ignored for Typescript Constructor Shorthands (link)).

Specific Changes

  • Removes existing @typescript-eslint/explicit-member-accessibility override from the .eslintrc.json file.
  • Adds the new @typescript-eslint/explicit-member-accessibility config under the rules object, with the accessibility to 'no-public', and ignoring cases where it's declared in constructors.

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 2, 2022 14:26
@coveralls
Copy link

coveralls commented May 2, 2022

Pull Request Test Coverage Report for Build 2516207688

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 287 unchanged lines in 25 files lost coverage.
  • Overall coverage decreased (-0.004%) to 84.479%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-ai/src/qnaCardBuilder.ts 1 84.48%
libraries/botbuilder-core/src/memoryTranscriptStore.ts 1 95.0%
libraries/botbuilder-ai/src/qnaMakerDialog.ts 2 85.15%
libraries/botbuilder-core/src/skills/skillConversationIdFactoryBase.ts 2 40.0%
libraries/botbuilder-core/src/skypeMentionNormalizeMiddleware.ts 2 80.95%
libraries/botbuilder-core/src/turnContextStateCollection.ts 2 79.31%
libraries/botbuilder-core/src/turnContext.ts 2 97.71%
libraries/botbuilder-ai-orchestrator/src/orchestratorBotComponent.ts 3 50.0%
libraries/botbuilder-ai/src/qnamaker-utils/languageServiceUtils.ts 3 82.64%
libraries/botbuilder-core/src/showTypingMiddleware.ts 3 86.54%
Totals Coverage Status
Change from base Build 2245574340: -0.004%
Covered Lines: 19904
Relevant Lines: 22312

💛 - Coveralls

@tracyboehrer tracyboehrer reopened this Jun 17, 2022
@tracyboehrer tracyboehrer merged commit f4425c4 into main Jul 12, 2022
@tracyboehrer tracyboehrer deleted the southworks/update/public-accessibility-rule branch July 12, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code quality] Remove public access modifier where it's unnecessary
3 participants