Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sku for Microsoft.BotService/botServices in 2 ARM templates #4195

Merged
merged 1 commit into from
Apr 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,16 @@
"contentVersion": "1.0.0.0",
"parameters": {
"botName": {
"type": "string",
"type": "string",
"minLength": 2
},
"botSku": {
"defaultValue": "F0",
"type": "string",
"metadata": {
"description": "The pricing tier of the Bot Service Registration. Acceptable values are F0 and S1."
}
},
"sku": {
"defaultValue": {
"name": "S1",
Expand Down Expand Up @@ -51,7 +58,7 @@
"properties": {
"name": "[parameters('botName')]",
"reserved": true,
"perSiteScaling": false,
"perSiteScaling": false,
"targetWorkerCount": 0,
"targetWorkerSizeId": 0
}
Expand Down Expand Up @@ -105,7 +112,7 @@
"containerSize": 0,
"dailyMemoryTimeQuota": 0,
"httpsOnly": false
}
}
},
{
"type": "Microsoft.Web/sites/config",
Expand Down Expand Up @@ -204,7 +211,7 @@
"location": "global",
"kind": "bot",
"sku": {
"name": "[parameters('botName')]"
"name": "[parameters('botSku')]"
},
"properties": {
"name": "[parameters('botName')]",
Expand Down Expand Up @@ -234,4 +241,4 @@
}
}
]
}
}
17 changes: 12 additions & 5 deletions testing/testbot/template/linux/template.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,16 @@
"contentVersion": "1.0.0.0",
"parameters": {
"botName": {
"type": "string",
"type": "string",
"minLength": 2
},
"botSku": {
"defaultValue": "F0",
"type": "string",
"metadata": {
"description": "The pricing tier of the Bot Service Registration. Acceptable values are F0 and S1."
}
},
"sku": {
"defaultValue": {
"name": "S1",
Expand Down Expand Up @@ -51,7 +58,7 @@
"properties": {
"name": "[parameters('botName')]",
"reserved": true,
"perSiteScaling": false,
"perSiteScaling": false,
"targetWorkerCount": 0,
"targetWorkerSizeId": 0
}
Expand Down Expand Up @@ -105,7 +112,7 @@
"containerSize": 0,
"dailyMemoryTimeQuota": 0,
"httpsOnly": false
}
}
},
{
"type": "Microsoft.Web/sites/config",
Expand Down Expand Up @@ -204,7 +211,7 @@
"location": "global",
"kind": "bot",
"sku": {
"name": "[parameters('botName')]"
"name": "[parameters('botSku')]"
},
"properties": {
"name": "[parameters('botName')]",
Expand Down Expand Up @@ -234,4 +241,4 @@
}
}
]
}
}