-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for CQA with unit tests. #4162
Merged
tracyboehrer
merged 23 commits into
microsoft:main
from
Arsh-Kashyap:Arsh-Kashyap/LanguageService
Apr 7, 2022
Merged
feat: Added support for CQA with unit tests. #4162
tracyboehrer
merged 23 commits into
microsoft:main
from
Arsh-Kashyap:Arsh-Kashyap/LanguageService
Apr 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-Kashyap/botbuilder-js into Arsh-Kashyap/LanguageService
Arsh-Kashyap
changed the title
Added support for CQA with unit tests.
feat: Added support for CQA with unit tests.
Mar 17, 2022
mrivera-ms
suggested changes
Mar 24, 2022
libraries/botbuilder-ai/src/qnamaker-utils/languageServiceUtils.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai/src/qnamaker-utils/languageServiceUtils.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-ai/src/qnamaker-utils/languageServiceUtils.ts
Outdated
Show resolved
Hide resolved
mrivera-ms
suggested changes
Mar 24, 2022
@Arsh-Kashyap, please add code coverage to Before:After: |
…o Arsh-Kashyap/LanguageService
mrivera-ms
suggested changes
Mar 31, 2022
Pull Request Test Coverage Report for Build 2106661739
💛 - Coveralls |
Thanks for the latest changes, @Arsh-Kashyap. I have resolved the comments that have been fixed since the previous review. A few issues:
|
mrivera-ms
reviewed
Apr 7, 2022
libraries/botbuilder-ai/src/qnamaker-utils/languageServiceUtils.ts
Outdated
Show resolved
Hide resolved
mrivera-ms
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
Added Language Service utils for querying Language Service via bot. DefaultAnswer can be configured from secrets file. Updated unit tests and added tests for CQA(Custom Question Answering).
How to test
yarn
andyarn build
in root folder of SDK.yarn build
in botbuilder-ai and botbuilder-dialogs in SDK.yarn link
in botbuilder-dialogs in sdk.yarn link botbuilder-dialogs
in botbuilder-ai. Then runyarn link
.npm install
,yarn link botbuilder-ai
andyarn link botbuilder-dialogs
in 48.customQABot-all-features.npm start
to test.Specific Changes
Testing
Added Language Service tests and updated existing tests.