Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#3922] Corrected GetConversationMembers to use TeamsInfo helper class rather… (#5874) #4151

Merged

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #3922

Description

This PR ports the changes in BotBuider-DotNet to Corrected GetConversationMembers in Adaptive.Runtime to use TeamsInfo helper class rather than rely on BotFrameworkAdapter functions that aren't available now that CoreBotAdapter derives from CloudAdapter and not BotFrameworkAdapter.

Specific Changes

  • getActitivityMemebers.ts
    • Remove BotFrameworkAdapter
    • Create a private function, which gets the connector client and returns the accounts info
  • getConversationsMemebers.ts
    • Remove BotFrameworkAdapter
    • Create a private function, which gets the connector client and returns the conversation's members info

Testing

These images show the unit tests passing after the changes.
image
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner March 9, 2022 20:33
@coveralls
Copy link

coveralls commented Mar 9, 2022

Pull Request Test Coverage Report for Build 1995610952

  • 16 of 30 (53.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 84.543%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/actions/getConversationMembers.ts 7 13 53.85%
libraries/botbuilder-dialogs-adaptive/src/actions/getActivityMembers.ts 9 17 52.94%
Totals Coverage Status
Change from base Build 1995608014: -0.03%
Covered Lines: 19716
Relevant Lines: 22090

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 9fa659c into main Mar 17, 2022
@mrivera-ms mrivera-ms deleted the southworks/port/correct-getConversationMembers-to-use-teaminfo branch March 17, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Corrected GetConversationMembers to use TeamsInfo helper class rather… (#5874)
5 participants