Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [SSO] Remove 'exchangeToken' validation from OauthPrompt #4138

Merged
merged 3 commits into from
Mar 11, 2022
Merged

fix: [SSO] Remove 'exchangeToken' validation from OauthPrompt #4138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bad831c
Remove validation for exchangeToken method
ceciliaavila Feb 24, 2022
a8662ac
Merge branch 'main' into southworks/fix/oauthprompt-token-exchange-va…
ceciliaavila Mar 2, 2022
e15a810
Merge branch 'main' into southworks/fix/oauthprompt-token-exchange-va…
mrivera-ms Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions libraries/botbuilder-dialogs/src/prompts/oauthPrompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,16 +456,6 @@ export class OAuthPrompt extends Dialog {
'expected by the bots active OAuthPrompt. Ensure these names match when sending the InvokeActivityInvalid ConnectionName in the TokenExchangeInvokeRequest'
)
);
} else if (!('exchangeToken' in context.adapter)) {
// Token Exchange not supported in the adapter
await context.sendActivity(
this.getTokenExchangeInvokeResponse(
StatusCodes.BAD_GATEWAY,
"The bot's BotAdapter does not support token exchange operations. Ensure the bot's Adapter supports the ExtendedUserTokenProvider interface."
)
);

throw new Error('OAuthPrompt.recognizeToken(): not supported by the current adapter');
} else {
let tokenExchangeResponse: TokenResponse;
try {
Expand Down