Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#3756] Ensure SDK packages and their dependencies support next Node.js LTS (16.x) #4046

Merged
merged 7 commits into from
Mar 21, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #3756

Description

This PR updates the CI checks to use Nodejs 16 and three failing tests to support the new node error messages.

Detailed Changes

  • Updated the following GitHub workflows to use Nodejs 16:
    • depcheck
    • lint
    • test-compat
    • test-consumer
    • test-repoutils
  • Added Nodejs 16 to the test matrix in the tests GitHub workflow.
  • Updated the following unit tests that were asserting an error message that changed in the new version of Node.
    • componentDialog.test
    • dialogSet.test
    • teamsActivityHandler.test

Testing

These images show the GitHub checks passing, some samples tested using Nodejs 16 and the unit tests executed successfully
image
image
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner January 7, 2022 20:45
@coveralls
Copy link

coveralls commented Jan 7, 2022

Pull Request Test Coverage Report for Build 1669282754

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.545%

Totals Coverage Status
Change from base Build 1660046049: 0.0%
Covered Lines: 19667
Relevant Lines: 22035

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit d28d61f into main Mar 21, 2022
@mrivera-ms mrivera-ms deleted the southworks/update/support-node-16 branch March 21, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure SDK packages and their dependencies support next Node.js LTS (16.x)
6 participants